commit edebf45712397f30c960fcba329784ba70819b9c
author nisse <nisse@webrtc.org> Thu Sep 15 07:20:40 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Sep 15 14:20:48 2016 +0000
tree ce8cfe10443751075677c777b0eadf8f69435103
parent 8faf9e047ee80b45d1a28d6c038cbd6e222f23cd

Use I420Buffer rather than VideoFrameBuffer when writing pixels.

Prepares for deleting VideoFrameBuffer::MutableDataY{,U,V}. objc
changes extracted from cl https://codereview.webrtc.org/2278883002/.

BUG=webrtc:5921

Review-Url: https://codereview.webrtc.org/2346453002
Cr-Commit-Position: refs/heads/master@{#14236}

webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm b/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm
index ef29049..5708346 100644
--- a/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm
+++ b/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm
@@ -740,17 +740,20 @@
     } else {
       // Applying rotation is only supported for legacy reasons and performance
       // is not critical here.
-      buffer = (rotation == webrtc::kVideoRotation_180)
-          ? I420Buffer::Create(adapted_width, adapted_height)
-          : I420Buffer::Create(adapted_height, adapted_width);
-      libyuv::I420Rotate(scaled_buffer->DataY(), scaled_buffer->StrideY(),
-                         scaled_buffer->DataU(), scaled_buffer->StrideU(),
-                         scaled_buffer->DataV(), scaled_buffer->StrideV(),
-                         buffer->MutableDataY(), buffer->StrideY(),
-                         buffer->MutableDataU(), buffer->StrideU(),
-                         buffer->MutableDataV(), buffer->StrideV(),
-                         crop_width, crop_height,
-                         static_cast<libyuv::RotationMode>(rotation));
+      rtc::scoped_refptr<webrtc::I420Buffer> rotated_buffer(
+          (rotation == webrtc::kVideoRotation_180)
+              ? I420Buffer::Create(adapted_width, adapted_height)
+              : I420Buffer::Create(adapted_height, adapted_width));
+      libyuv::I420Rotate(
+          scaled_buffer->DataY(), scaled_buffer->StrideY(),
+          scaled_buffer->DataU(), scaled_buffer->StrideU(),
+          scaled_buffer->DataV(), scaled_buffer->StrideV(),
+          rotated_buffer->MutableDataY(), rotated_buffer->StrideY(),
+          rotated_buffer->MutableDataU(), rotated_buffer->StrideU(),
+          rotated_buffer->MutableDataV(), rotated_buffer->StrideV(),
+          crop_width, crop_height,
+          static_cast<libyuv::RotationMode>(rotation));
+      buffer = rotated_buffer;
     }
   }