commit ed56cf44b0e2cf27a57b312372f56557899e8246
author Elad Alon <eladalon@webrtc.org> Tue Jul 02 11:20:23 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Tue Jul 02 14:40:20 2019 +0000
tree e62bd6e0fd31d5b80245dedbc1a2d5da426e7fad
parent e9d6e658c307fc0241d622756703d5c0d5388d80

Remove deprecated version of Vp8FrameBufferControllerFactory::Create

Bug: webrtc:10769
Change-Id: I31de2d21d5325eb4b175815739c2477352842425
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144381
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28448}

api/video_codecs/vp8_frame_buffer_controller.h

diff --git a/api/video_codecs/vp8_frame_buffer_controller.h b/api/video_codecs/vp8_frame_buffer_controller.h
index f304413..d3f6bc4 100644
--- a/api/video_codecs/vp8_frame_buffer_controller.h
+++ b/api/video_codecs/vp8_frame_buffer_controller.h
@@ -181,24 +181,10 @@
   virtual std::unique_ptr<Vp8FrameBufferControllerFactory> Clone() const = 0;
 
   // Create a Vp8FrameBufferController instance.
-  // TODO(bugs.webrtc.org/10769): Update downstream projects, then remove
-  // version without |fec_controller_override| and make the other version
-  // pure-virtual.
-  // (In theory, if neither version is overridden, stack overflow would occur.
-  // In practice, all subclasses override at least one version, and following
-  // the update of downstream projects, only one pure-virtual version will
-  // remain.)
-  virtual std::unique_ptr<Vp8FrameBufferController> Create(
-      const VideoCodec& codec,
-      const VideoEncoder::Settings& settings) {
-    return Create(codec, settings, nullptr);
-  }
   virtual std::unique_ptr<Vp8FrameBufferController> Create(
       const VideoCodec& codec,
       const VideoEncoder::Settings& settings,
-      FecControllerOverride* fec_controller_override) {
-    return Create(codec, settings);
-  }
+      FecControllerOverride* fec_controller_override) = 0;
 };
 
 }  // namespace webrtc