commit ebafdc84843256bac7f125ff637d7e006f67d595
author mbonadei <mbonadei@webrtc.org> Thu Dec 22 07:35:39 2016 -0800
committer Commit bot <commit-bot@chromium.org> Thu Dec 22 15:35:39 2016 +0000
tree f04a8c8c630e3c808a3a0715efd12eec8a66d216
parent 000d16396e748c7593ac41b24a876a6c20f0d277

Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

#include "webrtc/modules/video_coding/include/video_coding_defines.h"

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2598963002
Cr-Commit-Position: refs/heads/master@{#15760}

.gn

diff --git a/.gn b/.gn
index 0bd9b08..c381566 100644
--- a/.gn
+++ b/.gn
@@ -31,6 +31,7 @@
   "//webrtc/modules/audio_processing/*",
   "//webrtc/modules/media_file/*",
   "//webrtc/modules/pacing/*",
+  "//webrtc/modules/rtp_rtcp/*",
   "//webrtc/modules/video_capture/*",
   "//webrtc/modules/video_coding/*",
   "//webrtc/stats:rtc_stats",

webrtc/modules/BUILD.gn

diff --git a/webrtc/modules/BUILD.gn b/webrtc/modules/BUILD.gn
index ca519e7..40cbdf6 100644
--- a/webrtc/modules/BUILD.gn
+++ b/webrtc/modules/BUILD.gn
@@ -421,6 +421,7 @@
       "remote_bitrate_estimator/test/bwe_unittest.cc",
       "remote_bitrate_estimator/test/estimators/nada_unittest.cc",
       "remote_bitrate_estimator/test/metric_recorder_unittest.cc",
+      "rtp_rtcp/mocks/mock_rtp_rtcp.h",
       "rtp_rtcp/source/byte_io_unittest.cc",
       "rtp_rtcp/source/fec_test_helper.cc",
       "rtp_rtcp/source/fec_test_helper.h",

webrtc/modules/rtp_rtcp/BUILD.gn

diff --git a/webrtc/modules/rtp_rtcp/BUILD.gn b/webrtc/modules/rtp_rtcp/BUILD.gn
index 80f79c1..e806f07 100644
--- a/webrtc/modules/rtp_rtcp/BUILD.gn
+++ b/webrtc/modules/rtp_rtcp/BUILD.gn
@@ -20,7 +20,6 @@
     "include/rtp_rtcp.h",
     "include/rtp_rtcp_defines.h",
     "include/ulpfec_receiver.h",
-    "mocks/mock_rtp_rtcp.h",
     "source/byte_io.h",
     "source/dtmf_queue.cc",
     "source/dtmf_queue.h",
@@ -175,7 +174,12 @@
   deps = [
     "../..:webrtc_common",
     "../../api:transport_api",
+    "../../base:gtest_prod",
+    "../../base:rtc_base_approved",
+    "../../base:rtc_task_queue",
+    "../../call:call_interfaces",
     "../../common_video",
+    "../../logging:rtc_event_log_api",
     "../../system_wrappers",
     "../remote_bitrate_estimator",
   ]

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 27e6143..aa5df5f 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -22,7 +22,6 @@
 #include "webrtc/modules/include/module.h"
 #include "webrtc/modules/rtp_rtcp/include/flexfec_sender.h"
 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
-#include "webrtc/modules/video_coding/include/video_coding_defines.h"
 
 namespace webrtc {