Modifying MediaChannel to accept CopyOnWriteBuffer by value.
MediaChannel accepted the RtpPacket buffers through non-const pointer.
This is both unclear and introduces questions regarding if the buffer is
actually copied or not.
This change modifies the method to accept by value to reduce ambiguity.
Usage of the non-const data() method which could potentially copy the
buffer contents is also reduced in favor of cdata() which never copies.
Bug: None
Change-Id: I3b2daef0d31cb6aacceb46c86da3a40ce836242b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127340
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27090}diff --git a/media/base/rtp_data_engine.cc b/media/base/rtp_data_engine.cc
index be71f46..33c87cb 100644
--- a/media/base/rtp_data_engine.cc
+++ b/media/base/rtp_data_engine.cc
@@ -194,20 +194,20 @@
return true;
}
-void RtpDataMediaChannel::OnPacketReceived(rtc::CopyOnWriteBuffer* packet,
+void RtpDataMediaChannel::OnPacketReceived(rtc::CopyOnWriteBuffer packet,
int64_t /* packet_time_us */) {
RtpHeader header;
- if (!GetRtpHeader(packet->cdata(), packet->size(), &header)) {
+ if (!GetRtpHeader(packet.cdata(), packet.size(), &header)) {
return;
}
size_t header_length;
- if (!GetRtpHeaderLen(packet->cdata(), packet->size(), &header_length)) {
+ if (!GetRtpHeaderLen(packet.cdata(), packet.size(), &header_length)) {
return;
}
const char* data =
- packet->cdata<char>() + header_length + sizeof(kReservedSpace);
- size_t data_len = packet->size() - header_length - sizeof(kReservedSpace);
+ packet.cdata<char>() + header_length + sizeof(kReservedSpace);
+ size_t data_len = packet.size() - header_length - sizeof(kReservedSpace);
if (!receiving_) {
RTC_LOG(LS_WARNING) << "Not receiving packet " << header.ssrc << ":"