commit e66b83f8adff138247a030335360cba9f58704c7
author Niels Möller <nisse@webrtc.org> Mon May 30 12:57:41 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 30 13:05:03 2022 +0000
tree 2219f28a4ed90d85294dfb63ddc4bcb4504e8fa4
parent c85e4737404a1399b5d4ffd8a8eb4ac8cd77fcdd

Never pass a signed char to ctype macros like isdigit()

Bug: None
Change-Id: I451bb2c1f175a77aefbc8363009bf35a769fe941
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264442
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37037}

modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc

diff --git a/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc b/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc
index 57ebb54..ee72b07 100644
--- a/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc
+++ b/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc
@@ -286,7 +286,7 @@
 
     /* Packet loss test */
     if (!strcmp("-PL", argv[i])) {
-      if (isdigit(*argv[i + 1])) {
+      if (isdigit(static_cast<unsigned char>(*argv[i + 1]))) {
         packetLossPercent = atoi(argv[i + 1]);
         if ((packetLossPercent < 0) | (packetLossPercent > 100)) {
           printf("\nInvalid packet loss perentage \n");

modules/audio_coding/codecs/isac/main/test/simpleKenny.c

diff --git a/modules/audio_coding/codecs/isac/main/test/simpleKenny.c b/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
index 96b9b23..4446ff7 100644
--- a/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
+++ b/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
@@ -22,7 +22,6 @@
 #endif
 #endif
 
-#include <ctype.h>
 #include <math.h>
 
 /* include API */

modules/audio_coding/test/PCMFile.cc

diff --git a/modules/audio_coding/test/PCMFile.cc b/modules/audio_coding/test/PCMFile.cc
index 659f968..9ccfa49 100644
--- a/modules/audio_coding/test/PCMFile.cc
+++ b/modules/audio_coding/test/PCMFile.cc
@@ -62,7 +62,9 @@
   int16_t n = 0;
 
   // Removing trailing spaces.
-  while ((isspace(tmp_name[n]) || iscntrl(tmp_name[n])) && (tmp_name[n] != 0) &&
+  while ((isspace(static_cast<unsigned char>(tmp_name[n])) ||
+          iscntrl(static_cast<unsigned char>(tmp_name[n]))) &&
+         (static_cast<unsigned char>(tmp_name[n]) != 0) &&
          (n < MAX_FILE_NAME_LENGTH_BYTE)) {
     n++;
   }
@@ -73,7 +75,9 @@
   // Removing trailing spaces.
   n = (int16_t)(strlen(tmp_name) - 1);
   if (n >= 0) {
-    while ((isspace(tmp_name[n]) || iscntrl(tmp_name[n])) && (n >= 0)) {
+    while ((isspace(static_cast<unsigned char>(tmp_name[n])) ||
+            iscntrl(static_cast<unsigned char>(tmp_name[n]))) &&
+           (n >= 0)) {
       n--;
     }
   }

modules/audio_coding/test/TwoWayCommunication.cc

diff --git a/modules/audio_coding/test/TwoWayCommunication.cc b/modules/audio_coding/test/TwoWayCommunication.cc
index 91dbfd6..b42415a 100644
--- a/modules/audio_coding/test/TwoWayCommunication.cc
+++ b/modules/audio_coding/test/TwoWayCommunication.cc
@@ -10,7 +10,6 @@
 
 #include "TwoWayCommunication.h"
 
-#include <ctype.h>
 #include <stdio.h>
 #include <string.h>
 

modules/audio_coding/test/iSACTest.cc

diff --git a/modules/audio_coding/test/iSACTest.cc b/modules/audio_coding/test/iSACTest.cc
index 52f5a6a..3e51842 100644
--- a/modules/audio_coding/test/iSACTest.cc
+++ b/modules/audio_coding/test/iSACTest.cc
@@ -10,7 +10,6 @@
 
 #include "modules/audio_coding/test/iSACTest.h"
 
-#include <ctype.h>
 #include <stdio.h>
 #include <string.h>