commit e12c1fe8d99b51891f8b0e039e0972423024a562
author Mirko Bonadei <mbonadei@webrtc.org> Tue Jul 03 12:53:23 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Jul 04 10:35:27 2018 +0000
tree a51bedd02c7ae85059306568476b9e4189ee90b9
parent 36c69d511458f766e84d8d0cfa23ef0fda4c364e

Removing warning suppression flags from pc/.

Bug: webrtc:9251
Change-Id: Ic12126fc03309448fe71a17e6b65343949496f4f
Reviewed-on: https://webrtc-review.googlesource.com/86820
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23838}

pc/rtcstatscollector_unittest.cc

diff --git a/pc/rtcstatscollector_unittest.cc b/pc/rtcstatscollector_unittest.cc
index 0c4bc03..ea99c8d 100644
--- a/pc/rtcstatscollector_unittest.cc
+++ b/pc/rtcstatscollector_unittest.cc
@@ -110,7 +110,7 @@
 std::string IdForType(const RTCStatsReport* report) {
   auto stats_of_my_type = report->RTCStatsReport::GetStatsOfType<T>();
   // We cannot use ASSERT here, since we're within a function.
-  EXPECT_EQ(1, stats_of_my_type.size())
+  EXPECT_EQ(1U, stats_of_my_type.size())
       << "Unexpected number of stats of this type";
   if (stats_of_my_type.size() == 1) {
     return stats_of_my_type[0]->id();
@@ -1470,9 +1470,9 @@
   rtc::scoped_refptr<const RTCStatsReport> report = stats_->GetStatsReport();
 
   auto stats_of_my_type = report->GetStatsOfType<RTCMediaStreamStats>();
-  ASSERT_EQ(1, stats_of_my_type.size()) << "No stream in " << report->ToJson();
+  ASSERT_EQ(1U, stats_of_my_type.size()) << "No stream in " << report->ToJson();
   auto stats_of_track_type = report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  ASSERT_EQ(1, stats_of_track_type.size())
+  ASSERT_EQ(1U, stats_of_track_type.size())
       << "Wrong number of tracks in " << report->ToJson();
 
   RTCMediaStreamStats expected_local_stream(stats_of_my_type[0]->id(),
@@ -1533,9 +1533,9 @@
   rtc::scoped_refptr<const RTCStatsReport> report = stats_->GetStatsReport();
 
   auto stats_of_my_type = report->GetStatsOfType<RTCMediaStreamStats>();
-  ASSERT_EQ(1, stats_of_my_type.size()) << "No stream in " << report->ToJson();
+  ASSERT_EQ(1U, stats_of_my_type.size()) << "No stream in " << report->ToJson();
   auto stats_of_track_type = report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  ASSERT_EQ(1, stats_of_track_type.size())
+  ASSERT_EQ(1U, stats_of_track_type.size())
       << "Wrong number of tracks in " << report->ToJson();
   ASSERT_TRUE(*(stats_of_track_type[0]->remote_source));
 
@@ -1598,7 +1598,7 @@
   rtc::scoped_refptr<const RTCStatsReport> report = stats_->GetStatsReport();
 
   auto stats_of_track_type = report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  ASSERT_EQ(1, stats_of_track_type.size());
+  ASSERT_EQ(1U, stats_of_track_type.size());
 
   RTCInboundRTPStreamStats expected_audio("RTCInboundRTPAudioStream_1",
                                           report->timestamp_us());
@@ -1775,9 +1775,9 @@
   rtc::scoped_refptr<const RTCStatsReport> report = stats_->GetStatsReport();
 
   auto stats_of_my_type = report->GetStatsOfType<RTCOutboundRTPStreamStats>();
-  ASSERT_EQ(1, stats_of_my_type.size());
+  ASSERT_EQ(1U, stats_of_my_type.size());
   auto stats_of_track_type = report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  ASSERT_EQ(1, stats_of_track_type.size());
+  ASSERT_EQ(1U, stats_of_track_type.size());
 
   RTCOutboundRTPStreamStats expected_video(stats_of_my_type[0]->id(),
                                            report->timestamp_us());
@@ -2086,11 +2086,11 @@
 
   std::vector<const RTCMediaStreamTrackStats*> track_stats =
       report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  EXPECT_EQ(1, track_stats.size());
+  EXPECT_EQ(1U, track_stats.size());
 
   std::vector<const RTCRTPStreamStats*> rtp_stream_stats =
       report->GetStatsOfType<RTCRTPStreamStats>();
-  EXPECT_EQ(0, rtp_stream_stats.size());
+  EXPECT_EQ(0U, rtp_stream_stats.size());
 }
 
 TEST_F(RTCStatsCollectorTest, DoNotCrashOnSsrcChange) {
@@ -2106,7 +2106,7 @@
 
   std::vector<const RTCMediaStreamTrackStats*> track_stats =
       report->GetStatsOfType<RTCMediaStreamTrackStats>();
-  EXPECT_EQ(1, track_stats.size());
+  EXPECT_EQ(1U, track_stats.size());
 }
 
 // Used for test below, to test calling GetStatsReport during a callback.