commit dfeb0dff731d24ec54570d026312d34237b50855
author Markus Handell <handellm@webrtc.org> Mon Mar 16 22:20:47 2020 +0100
committer Commit Bot <commit-bot@chromium.org> Fri Mar 20 14:27:02 2020 +0000
tree 5b222182d9c0de715e3036e0659275934f128b39
parent f4306ebfeabde48163e7a0de56aa5e3134f466d1

RtpParameters: respect https://abseil.io/tips/1.

This CL replaces a few usages of const std::string& with
absl::string_view, to comply closer with
https://abseil.io/tips/1.

Bug: webrtc:11428
Change-Id: Ibf6fac9b084cb21e17db63f73d667793ab9cafeb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170466
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30845}

api/rtp_parameters.h

diff --git a/api/rtp_parameters.h b/api/rtp_parameters.h
index ee51b01..cd7f029 100644
--- a/api/rtp_parameters.h
+++ b/api/rtp_parameters.h
@@ -17,6 +17,7 @@
 #include <string>
 #include <vector>
 
+#include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 #include "api/media_types.h"
 #include "api/rtp_transceiver_direction.h"
@@ -230,9 +231,9 @@
 
   // Constructors for convenience.
   RtpHeaderExtensionCapability();
-  explicit RtpHeaderExtensionCapability(const std::string& uri);
-  RtpHeaderExtensionCapability(const std::string& uri, int preferred_id);
-  RtpHeaderExtensionCapability(const std::string& uri,
+  explicit RtpHeaderExtensionCapability(std::string uri);
+  RtpHeaderExtensionCapability(std::string uri, int preferred_id);
+  RtpHeaderExtensionCapability(std::string uri,
                                int preferred_id,
                                RtpTransceiverDirection direction);
   ~RtpHeaderExtensionCapability();
@@ -249,23 +250,23 @@
 // RTP header extension, see RFC8285.
 struct RTC_EXPORT RtpExtension {
   RtpExtension();
-  RtpExtension(const std::string& uri, int id);
-  RtpExtension(const std::string& uri, int id, bool encrypt);
+  RtpExtension(std::string uri, int id);
+  RtpExtension(std::string uri, int id, bool encrypt);
   ~RtpExtension();
   std::string ToString() const;
   bool operator==(const RtpExtension& rhs) const {
     return uri == rhs.uri && id == rhs.id && encrypt == rhs.encrypt;
   }
-  static bool IsSupportedForAudio(const std::string& uri);
-  static bool IsSupportedForVideo(const std::string& uri);
+  static bool IsSupportedForAudio(absl::string_view uri);
+  static bool IsSupportedForVideo(absl::string_view uri);
   // Return "true" if the given RTP header extension URI may be encrypted.
-  static bool IsEncryptionSupported(const std::string& uri);
+  static bool IsEncryptionSupported(absl::string_view uri);
 
   // Returns the named header extension if found among all extensions,
   // nullptr otherwise.
   static const RtpExtension* FindHeaderExtensionByUri(
       const std::vector<RtpExtension>& extensions,
-      const std::string& uri);
+      absl::string_view uri);
 
   // Return a list of RTP header extensions with the non-encrypted extensions
   // removed if both the encrypted and non-encrypted extension is present for