Prevent channels being set on stopped transceiver.
Fixing bug that allows a channel to be set on a stopped transceiver.
This CL contains the following refactoring:
1. Extracted ChannelInterface from BaseChannel
2. Unified SetXxxMediaChannel (Voice, Video) into SetMediaChannel
Bug: webrtc:9932
Change-Id: I2fbf00c823b7848ad4f2acb6e80b1b58ac45ee38
Reviewed-on: https://webrtc-review.googlesource.com/c/110564
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25641}diff --git a/pc/peerconnection.h b/pc/peerconnection.h
index fe4d777..b5ae9d2 100644
--- a/pc/peerconnection.h
+++ b/pc/peerconnection.h
@@ -719,7 +719,7 @@
SessionError session_error() const { return session_error_; }
const std::string& session_error_desc() const { return session_error_desc_; }
- cricket::BaseChannel* GetChannel(const std::string& content_name);
+ cricket::ChannelInterface* GetChannel(const std::string& content_name);
// Get current SSL role used by SCTP's underlying transport.
bool GetSctpSslRole(rtc::SSLRole* role);
@@ -922,9 +922,9 @@
// Destroys the RTP data channel and/or the SCTP data channel and clears it.
void DestroyDataChannel();
- // Destroys the given BaseChannel. The channel cannot be accessed after this
- // method is called.
- void DestroyBaseChannel(cricket::BaseChannel* channel);
+ // Destroys the given ChannelInterface.
+ // The channel cannot be accessed after this method is called.
+ void DestroyChannelInterface(cricket::ChannelInterface* channel);
// JsepTransportController::Observer override.
//