commit dd460e2aa2b7b8a9ad79d2b6a7945a2b7d301eaa
author kjellander <kjellander@webrtc.org> Wed Apr 12 12:06:13 2017 -0700
committer Commit bot <commit-bot@chromium.org> Wed Apr 12 19:06:13 2017 +0000
tree d823c533dd5bfe34741dd59de01ec9a606e5c05d
parent 06034c7d6401b8e447aac98fd062b87523ae5f4f

Fix lint errors to enable stricter PyLint rules

These fixes are needed to avoid errors after submitting
https://codereview.webrtc.org/2737963003

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2812273002
Cr-Commit-Position: refs/heads/master@{#17679}

tools-webrtc/vim/webrtc.ycm_extra_conf.py

diff --git a/tools-webrtc/vim/webrtc.ycm_extra_conf.py b/tools-webrtc/vim/webrtc.ycm_extra_conf.py
index b716e45..e954639 100644
--- a/tools-webrtc/vim/webrtc.ycm_extra_conf.py
+++ b/tools-webrtc/vim/webrtc.ycm_extra_conf.py
@@ -61,16 +61,16 @@
 import sys
 
 # Flags from YCM's default config.
-_default_flags = [
+_DEFAULT_FLAGS = [
   '-DUSE_CLANG_COMPLETER',
   '-std=c++11',
   '-x',
   'c++',
 ]
 
-_header_alternates = ('.cc', '.cpp', '.c', '.mm', '.m')
+_HEADER_ALTERNATES = ('.cc', '.cpp', '.c', '.mm', '.m')
 
-_extension_flags = {
+_EXTENSION_FLAGS = {
   '.m': ['-x', 'objective-c'],
   '.mm': ['-x', 'objective-c++'],
 }
@@ -302,7 +302,7 @@
 
   basename, extension = os.path.splitext(filename)
   if extension == '.h':
-    candidates = [basename + ext for ext in _header_alternates]
+    candidates = [basename + ext for ext in _HEADER_ALTERNATES]
   else:
     candidates = [filename]
 
@@ -314,7 +314,7 @@
       buildable_extension = os.path.splitext(candidate)[1]
       break
 
-  additional_flags += _extension_flags.get(buildable_extension, [])
+  additional_flags += _EXTENSION_FLAGS.get(buildable_extension, [])
 
   if not clang_line:
     # If ninja didn't know about filename or it's companion files, then try a
@@ -349,7 +349,7 @@
   # determine the flags again.
   should_cache_flags_for_file = bool(clang_flags)
 
-  final_flags = _default_flags + clang_flags
+  final_flags = _DEFAULT_FLAGS + clang_flags
 
   return {
     'flags': final_flags,