commit d8ed0c1f17726ef27965a490fb72ccefcbf682b0
author Junji Watanabe <jwata@google.com> Tue Dec 06 15:25:38 2022 +0900
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 06 07:18:28 2022 +0000
tree 33e8e8828e4afcb4aedb4dcea8dafba34e9b890e
parent e093c481bf8fd8e141fee4c007d63da488ce0ef5

Specify DEPS ninja path directly in build scripts instead of depot_tools/ninja wrapper

It's better to avoid calling DEPOT_TOOLS_PATH because ninja binaries in depot_tools will be removed soon.
Technically, it would work because depot_tools/ninja 'wrapper' can find the DEPS ninja path. But it's better to specify the ninja path directly instead of relying on the wrapper.

Bug: chromium:1340825
Change-Id: I992c12601e86be003acdb39ce6d29be817dc7522
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38815}

tools_webrtc/ios/build_ios_libs.py

diff --git a/tools_webrtc/ios/build_ios_libs.py b/tools_webrtc/ios/build_ios_libs.py
index 093a002..764c378 100755
--- a/tools_webrtc/ios/build_ios_libs.py
+++ b/tools_webrtc/ios/build_ios_libs.py
@@ -197,7 +197,7 @@
   logging.info('Building target: %s', gn_target_name)
 
   cmd = [
-      os.path.join(find_depot_tools.DEPOT_TOOLS_PATH, 'ninja'),
+      os.path.join(SRC_DIR, 'third_party', 'ninja', 'ninja'),
       '-C',
       output_dir,
       gn_target_name,