Add new video codec factories
This CL adds interfaces for the new video codec factories and wires them
up in WebRtcVideoEngine. The default behavior is unmodified however, and
the new code is currently unused except for the tests.
A follow-up CL will be uploaded for exposing them in the
PeerConnectionFactory API: https://codereview.webrtc.org/3004353002/.
BUG=webrtc:7925
R=andersc@webrtc.org, stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/3007073002 .
Cr-Commit-Position: refs/heads/master@{#19828}
diff --git a/webrtc/media/engine/webrtcvideoencoderfactory.h b/webrtc/media/engine/webrtcvideoencoderfactory.h
index 208ab8b..284f1ef 100644
--- a/webrtc/media/engine/webrtcvideoencoderfactory.h
+++ b/webrtc/media/engine/webrtcvideoencoderfactory.h
@@ -22,6 +22,8 @@
namespace cricket {
+// Deprecated. Use webrtc::VideoEncoderFactory instead.
+// https://bugs.chromium.org/p/webrtc/issues/detail?id=7925
class WebRtcVideoEncoderFactory {
public:
virtual ~WebRtcVideoEncoderFactory() {}
@@ -36,9 +38,7 @@
// Returns true if encoders created by this factory of the given codec type
// will use internal camera sources, meaning that they don't require/expect
- // frames to be delivered via webrtc::VideoEncoder::Encode. This flag is used
- // as the internal_source parameter to
- // webrtc::ViEExternalCodec::RegisterExternalSendCodec.
+ // frames to be delivered via webrtc::VideoEncoder::Encode.
virtual bool EncoderTypeHasInternalSource(webrtc::VideoCodecType type) const {
return false;
}