commit d419db9a9e551cc962575b2d035d11f7160d5ec4
author Peter Hanspers <peterhanspers@webrtc.org> Mon Oct 15 22:47:38 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Tue Oct 16 09:24:44 2018 +0000
tree ab0cb2953e6ae56a9d741dca6374d76515906ec1
parent 2e47f7c4eeb9c2a9cfe5e4e8b079db5b127cdf8b

Adding support for logging severity LS_NONE.

Bug: webrtc:8735
Change-Id: I07247ce67983f873febb8d8d32c25032a4608eae
Reviewed-on: https://webrtc-review.googlesource.com/c/40400
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25197}

sdk/objc/api/logging/RTCCallbackLogger.mm

diff --git a/sdk/objc/api/logging/RTCCallbackLogger.mm b/sdk/objc/api/logging/RTCCallbackLogger.mm
index 8440d63..da60c2b 100644
--- a/sdk/objc/api/logging/RTCCallbackLogger.mm
+++ b/sdk/objc/api/logging/RTCCallbackLogger.mm
@@ -86,6 +86,8 @@
       return rtc::LS_WARNING;
     case RTCLoggingSeverityError:
       return rtc::LS_ERROR;
+    case RTCLoggingSeverityNone:
+      return rtc::LS_NONE;
   }
 }
 

sdk/objc/base/RTCLogging.h

diff --git a/sdk/objc/base/RTCLogging.h b/sdk/objc/base/RTCLogging.h
index be62db2..754945c 100644
--- a/sdk/objc/base/RTCLogging.h
+++ b/sdk/objc/base/RTCLogging.h
@@ -18,6 +18,7 @@
   RTCLoggingSeverityInfo,
   RTCLoggingSeverityWarning,
   RTCLoggingSeverityError,
+  RTCLoggingSeverityNone,
 };
 
 // Wrapper for C++ RTC_LOG(sev) macros.

sdk/objc/base/RTCLogging.mm

diff --git a/sdk/objc/base/RTCLogging.mm b/sdk/objc/base/RTCLogging.mm
index 5c8f9fb..e8dae02 100644
--- a/sdk/objc/base/RTCLogging.mm
+++ b/sdk/objc/base/RTCLogging.mm
@@ -22,6 +22,8 @@
       return rtc::LS_WARNING;
     case RTCLoggingSeverityError:
       return rtc::LS_ERROR;
+    case RTCLoggingSeverityNone:
+      return rtc::LS_NONE;
   }
 }
 

sdk/objc/unittests/RTCCallbackLogger_xctest.m

diff --git a/sdk/objc/unittests/RTCCallbackLogger_xctest.m b/sdk/objc/unittests/RTCCallbackLogger_xctest.m
index 4a0a2b3..fbebb99 100644
--- a/sdk/objc/unittests/RTCCallbackLogger_xctest.m
+++ b/sdk/objc/unittests/RTCCallbackLogger_xctest.m
@@ -66,6 +66,25 @@
   [self waitForExpectations:@[ callbackExpectation ] timeout:10.0];
 }
 
+- (void)testCallbackDoesNotgetCalledForSeverityNone {
+  self.logger.severity = RTCLoggingSeverityNone;
+
+  XCTestExpectation *callbackExpectation = [self expectationWithDescription:@"unexpectedCallback"];
+
+  [self.logger start:^(NSString *message) {
+    [callbackExpectation fulfill];
+    XCTAssertTrue(false);
+  }];
+
+  RTCLogInfo("Just some info");
+  RTCLogWarning("Warning warning");
+  RTCLogError("Horrible error");
+
+  XCTWaiter *waiter = [[XCTWaiter alloc] init];
+  XCTWaiterResult result = [waiter waitForExpectations:@[ callbackExpectation ] timeout:1.0];
+  XCTAssertEqual(result, XCTWaiterResultTimedOut);
+}
+
 - (void)testStartingWithNilCallbackDoesNotCrash {
   [self.logger start:nil];