Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.
Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
diff --git a/modules/video_coding/codecs/h264/h264.cc b/modules/video_coding/codecs/h264/h264.cc
index ca6ce3c..8324b7c 100644
--- a/modules/video_coding/codecs/h264/h264.cc
+++ b/modules/video_coding/codecs/h264/h264.cc
@@ -102,7 +102,7 @@
RTC_LOG(LS_INFO) << "Creating H264EncoderImpl.";
return std::make_unique<H264EncoderImpl>(codec);
#else
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return nullptr;
#endif
}
@@ -127,7 +127,7 @@
RTC_LOG(LS_INFO) << "Creating H264DecoderImpl.";
return std::make_unique<H264DecoderImpl>();
#else
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return nullptr;
#endif
}
diff --git a/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/modules/video_coding/codecs/h264/h264_encoder_impl.cc
index 4256926..b8c6916 100644
--- a/modules/video_coding/codecs/h264/h264_encoder_impl.cc
+++ b/modules/video_coding/codecs/h264/h264_encoder_impl.cc
@@ -81,7 +81,7 @@
case videoFrameTypeInvalid:
break;
}
- RTC_NOTREACHED() << "Unexpected/invalid frame type: " << type;
+ RTC_DCHECK_NOTREACHED() << "Unexpected/invalid frame type: " << type;
return VideoFrameType::kEmptyFrame;
}
@@ -537,7 +537,7 @@
} else if (codec_.mode == VideoCodecMode::kScreensharing) {
encoder_params.iUsageType = SCREEN_CONTENT_REAL_TIME;
} else {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
encoder_params.iPicWidth = configurations_[i].width;
encoder_params.iPicHeight = configurations_[i].height;
diff --git a/modules/video_coding/codecs/h264/include/h264_globals.h b/modules/video_coding/codecs/h264/include/h264_globals.h
index 073d8f9..b61dc8c 100644
--- a/modules/video_coding/codecs/h264/include/h264_globals.h
+++ b/modules/video_coding/codecs/h264/include/h264_globals.h
@@ -52,7 +52,7 @@
} else if (mode == H264PacketizationMode::SingleNalUnit) {
return "SingleNalUnit";
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return "";
}
diff --git a/modules/video_coding/codecs/interface/libvpx_interface.cc b/modules/video_coding/codecs/interface/libvpx_interface.cc
index b24922f..4f33bef 100644
--- a/modules/video_coding/codecs/interface/libvpx_interface.cc
+++ b/modules/video_coding/codecs/interface/libvpx_interface.cc
@@ -133,7 +133,7 @@
case VP9E_SET_POSTENCODE_DROP:
return vpx_codec_control(ctx, VP9E_SET_POSTENCODE_DROP, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -181,7 +181,7 @@
// Might be intended for uint32_t but int literal used, try fallback.
return codec_control(ctx, ctrl_id, static_cast<uint32_t>(param));
}
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -199,7 +199,7 @@
case VP9E_GET_LEVEL:
return vpx_codec_control(ctx, VP9E_GET_LEVEL, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -213,7 +213,7 @@
case VP9E_SET_ROI_MAP:
return vpx_codec_control(ctx, VP9E_SET_ROI_MAP, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -227,7 +227,7 @@
case VP9E_GET_ACTIVEMAP:
return vpx_codec_control(ctx, VP8E_SET_ACTIVEMAP, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -239,7 +239,7 @@
case VP8E_SET_SCALEMODE:
return vpx_codec_control(ctx, VP8E_SET_SCALEMODE, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -251,7 +251,7 @@
case VP9E_SET_SVC_PARAMETERS:
return vpx_codec_control_(ctx, VP9E_SET_SVC_PARAMETERS, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -263,7 +263,7 @@
case VP9E_SET_SVC_FRAME_DROP_LAYER:
return vpx_codec_control_(ctx, VP9E_SET_SVC_FRAME_DROP_LAYER, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -277,7 +277,7 @@
case VP9E_REGISTER_CX_CALLBACK:
return vpx_codec_control_(ctx, VP9E_REGISTER_CX_CALLBACK, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -291,7 +291,7 @@
case VP9E_GET_SVC_LAYER_ID:
return vpx_codec_control_(ctx, VP9E_GET_SVC_LAYER_ID, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -306,7 +306,7 @@
case VP9E_GET_SVC_REF_FRAME_CONFIG:
return vpx_codec_control_(ctx, VP9E_GET_SVC_REF_FRAME_CONFIG, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -319,7 +319,7 @@
case VP9E_SET_SVC_SPATIAL_LAYER_SYNC:
return vpx_codec_control_(ctx, VP9E_SET_SVC_SPATIAL_LAYER_SYNC, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
@@ -331,7 +331,7 @@
case VP9E_SET_EXTERNAL_RATE_CONTROL:
return vpx_codec_control_(ctx, VP9E_SET_EXTERNAL_RATE_CONTROL, param);
default:
- RTC_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
+ RTC_DCHECK_NOTREACHED() << "Unsupported libvpx ctrl_id: " << ctrl_id;
}
return VPX_CODEC_ERROR;
}
diff --git a/modules/video_coding/codecs/multiplex/multiplex_decoder_adapter.cc b/modules/video_coding/codecs/multiplex/multiplex_decoder_adapter.cc
index e1bf598..0ad3d38 100644
--- a/modules/video_coding/codecs/multiplex/multiplex_decoder_adapter.cc
+++ b/modules/video_coding/codecs/multiplex/multiplex_decoder_adapter.cc
@@ -36,11 +36,11 @@
adapter_->Decoded(stream_idx_, &decoded_image, decode_time_ms, qp);
}
int32_t Decoded(VideoFrame& decoded_image) override {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return WEBRTC_VIDEO_CODEC_OK;
}
int32_t Decoded(VideoFrame& decoded_image, int64_t decode_time_ms) override {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return WEBRTC_VIDEO_CODEC_OK;
}
diff --git a/modules/video_coding/codecs/test/video_codec_unittest.h b/modules/video_coding/codecs/test/video_codec_unittest.h
index 13bcbf0..7d05882 100644
--- a/modules/video_coding/codecs/test/video_codec_unittest.h
+++ b/modules/video_coding/codecs/test/video_codec_unittest.h
@@ -54,11 +54,11 @@
: test_(test) {}
int32_t Decoded(VideoFrame& frame) override {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return -1;
}
int32_t Decoded(VideoFrame& frame, int64_t decode_time_ms) override {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return -1;
}
void Decoded(VideoFrame& frame,
diff --git a/modules/video_coding/codecs/test/video_encoder_decoder_instantiation_tests.cc b/modules/video_coding/codecs/test/video_encoder_decoder_instantiation_tests.cc
index e7a7f7d..41f2304 100644
--- a/modules/video_coding/codecs/test/video_encoder_decoder_instantiation_tests.cc
+++ b/modules/video_coding/codecs/test/video_encoder_decoder_instantiation_tests.cc
@@ -73,7 +73,7 @@
encoder_factory_ = CreateObjCEncoderFactory();
decoder_factory_ = CreateObjCDecoderFactory();
#else
- RTC_NOTREACHED() << "Only support Android and iOS.";
+ RTC_DCHECK_NOTREACHED() << "Only support Android and iOS.";
#endif
}
diff --git a/modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc b/modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc
index 0020c80..03da293 100644
--- a/modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc
+++ b/modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc
@@ -350,7 +350,7 @@
EXPECT_FALSE(contains_pps) << "Delta frame should not contain PPS.";
EXPECT_FALSE(contains_idr) << "Delta frame should not contain IDR.";
} else {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
}
diff --git a/modules/video_coding/codecs/test/videocodec_test_libvpx.cc b/modules/video_coding/codecs/test/videocodec_test_libvpx.cc
index 0eb0d5a..062375b 100644
--- a/modules/video_coding/codecs/test/videocodec_test_libvpx.cc
+++ b/modules/video_coding/codecs/test/videocodec_test_libvpx.cc
@@ -49,7 +49,7 @@
} else if (codec == kVideoCodecVP9) {
EXPECT_TRUE(vp9::GetQp(encoded_frame.data(), encoded_frame.size(), &qp));
} else {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
EXPECT_EQ(encoded_frame.qp_, qp) << "Encoder QP != parsed bitstream QP.";
}
diff --git a/modules/video_coding/codecs/vp8/default_temporal_layers.cc b/modules/video_coding/codecs/vp8/default_temporal_layers.cc
index 4de8d91..94860da 100644
--- a/modules/video_coding/codecs/vp8/default_temporal_layers.cc
+++ b/modules/video_coding/codecs/vp8/default_temporal_layers.cc
@@ -78,10 +78,10 @@
// 0 0 ...
return {0, 3, 2, 3, 1, 3, 2, 3};
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return {0};
}
@@ -236,10 +236,10 @@
{"----", {kReference, kReference, kReferenceAndUpdate}},
{"----", {kReference, kReference, kReference, kFreezeEntropy}}};
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return {{"", {kNone, kNone, kNone}}};
}
@@ -694,7 +694,7 @@
return template_structure;
}
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
// To make the compiler happy!
return template_structure;
}
@@ -725,7 +725,7 @@
{0}, {4, 6, 8}, {4, 6, 8}, {4, 8, 10},
{4, 8}, {8, 10, 12}, {8, 10, 12}, {8, 12, 14}};
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return {};
}
}
diff --git a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc
index 0d6fdfa..44a379f 100644
--- a/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc
+++ b/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc
@@ -205,7 +205,7 @@
break;
}
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
}
@@ -1357,7 +1357,7 @@
MaybeUpdatePixelFormat(VPX_IMG_FMT_NV12);
break;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
// Prepare `raw_images_` from `mapped_buffer` and, if simulcast, scaled
@@ -1399,10 +1399,11 @@
<< " instead of "
<< VideoFrameBufferTypeToString(mapped_buffer->type())
<< ". Can't encode frame.";
- RTC_NOTREACHED() << "Scaled buffer type "
- << VideoFrameBufferTypeToString(scaled_buffer->type())
- << " is not compatible with mapped buffer type "
- << VideoFrameBufferTypeToString(mapped_buffer->type());
+ RTC_DCHECK_NOTREACHED()
+ << "Scaled buffer type "
+ << VideoFrameBufferTypeToString(scaled_buffer->type())
+ << " is not compatible with mapped buffer type "
+ << VideoFrameBufferTypeToString(mapped_buffer->type());
return {};
}
SetRawImagePlanes(&raw_images_[i], scaled_buffer);
diff --git a/modules/video_coding/codecs/vp8/screenshare_layers.cc b/modules/video_coding/codecs/vp8/screenshare_layers.cc
index 27d070f..71db0b2 100644
--- a/modules/video_coding/codecs/vp8/screenshare_layers.cc
+++ b/modules/video_coding/codecs/vp8/screenshare_layers.cc
@@ -212,7 +212,7 @@
++stats_.num_dropped_frames_;
break;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
DependencyInfo dependency_info;
@@ -446,7 +446,7 @@
return template_structure;
}
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
// To make the compiler happy!
return template_structure;
}
diff --git a/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
index dd2dad6..e5b3bd4 100644
--- a/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
+++ b/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
@@ -565,7 +565,7 @@
} else if (flags == -1) {
dropped_frame = true;
} else {
- RTC_NOTREACHED() << "Unexpected flags";
+ RTC_DCHECK_NOTREACHED() << "Unexpected flags";
}
clock_.AdvanceTime(TimeDelta::Millis(1000 / 5));
}
diff --git a/modules/video_coding/codecs/vp9/include/vp9_globals.h b/modules/video_coding/codecs/vp9/include/vp9_globals.h
index 840d63e..bbd83f3 100644
--- a/modules/video_coding/codecs/vp9/include/vp9_globals.h
+++ b/modules/video_coding/codecs/vp9/include/vp9_globals.h
@@ -131,7 +131,7 @@
pid_diff[7][1] = 2;
break;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
}
diff --git a/modules/video_coding/codecs/vp9/libvpx_vp9_decoder.cc b/modules/video_coding/codecs/vp9/libvpx_vp9_decoder.cc
index 40b4d82..5d0f380 100644
--- a/modules/video_coding/codecs/vp9/libvpx_vp9_decoder.cc
+++ b/modules/video_coding/codecs/vp9/libvpx_vp9_decoder.cc
@@ -64,7 +64,7 @@
transfer = ColorSpace::TransferID::kBT2020_10;
break;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
matrix = ColorSpace::MatrixID::kBT2020_NCL;
diff --git a/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc b/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc
index c32673d..443efc2 100644
--- a/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc
+++ b/modules/video_coding/codecs/vp9/libvpx_vp9_encoder.cc
@@ -573,7 +573,7 @@
case VP9Profile::kProfile1:
// Encoding of profile 1 is not implemented. It would require extended
// support for I444, I422, and I440 buffers.
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
case VP9Profile::kProfile2:
img_fmt = VPX_IMG_FMT_I42016;
@@ -833,7 +833,7 @@
libvpx_->codec_control(encoder_, VP9E_SET_SVC_INTER_LAYER_PRED, 2);
break;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
memset(&svc_drop_frame_, 0, sizeof(svc_drop_frame_));
@@ -1111,7 +1111,7 @@
break;
}
case VP9Profile::kProfile1: {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
case VP9Profile::kProfile2: {
@@ -2001,7 +2001,7 @@
break;
}
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
return mapped_buffer;
}
diff --git a/modules/video_coding/codecs/vp9/vp9.cc b/modules/video_coding/codecs/vp9/vp9.cc
index 9570e53..7b787f3 100644
--- a/modules/video_coding/codecs/vp9/vp9.cc
+++ b/modules/video_coding/codecs/vp9/vp9.cc
@@ -77,7 +77,7 @@
LibvpxInterface::Create(),
FieldTrialBasedConfig());
#else
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return nullptr;
#endif
}
@@ -88,7 +88,7 @@
return std::make_unique<LibvpxVp9Encoder>(codec, LibvpxInterface::Create(),
FieldTrialBasedConfig());
#else
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return nullptr;
#endif
}
@@ -106,7 +106,7 @@
#ifdef RTC_ENABLE_VP9
return std::make_unique<LibvpxVp9Decoder>();
#else
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return nullptr;
#endif
}
diff --git a/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc b/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc
index f399c59..181550c 100644
--- a/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc
+++ b/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc
@@ -79,7 +79,7 @@
// TODO(phoglund): this limit is being hit in tests since Oct 5 2016.
// See https://bugs.chromium.org/p/webrtc/issues/detail?id=6484.
- // RTC_NOTREACHED();
+ // RTC_DCHECK_NOTREACHED();
}
}
}
diff --git a/modules/video_coding/frame_buffer.cc b/modules/video_coding/frame_buffer.cc
index 937534a..787da1e 100644
--- a/modules/video_coding/frame_buffer.cc
+++ b/modules/video_coding/frame_buffer.cc
@@ -241,7 +241,7 @@
case kStateEmpty:
// Should only be set to empty through Reset().
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
_state = state;
diff --git a/modules/video_coding/h264_packet_buffer.cc b/modules/video_coding/h264_packet_buffer.cc
index 7b821a1..6096665 100644
--- a/modules/video_coding/h264_packet_buffer.cc
+++ b/modules/video_coding/h264_packet_buffer.cc
@@ -118,7 +118,7 @@
}
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return result;
}
diff --git a/modules/video_coding/jitter_buffer.cc b/modules/video_coding/jitter_buffer.cc
index c3b0961..4c6015e 100644
--- a/modules/video_coding/jitter_buffer.cc
+++ b/modules/video_coding/jitter_buffer.cc
@@ -497,7 +497,7 @@
RecycleFrameBuffer(frame);
return kFlushIndicator;
default:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
}
return buffer_state;
}
diff --git a/modules/video_coding/jitter_estimator.cc b/modules/video_coding/jitter_estimator.cc
index 89cf51f..87848ae 100644
--- a/modules/video_coding/jitter_estimator.cc
+++ b/modules/video_coding/jitter_estimator.cc
@@ -246,7 +246,7 @@
hMh_sigma = deltaFSBytes * Mh[0] + Mh[1] + sigma;
if ((hMh_sigma < 1e-9 && hMh_sigma >= 0) ||
(hMh_sigma > -1e-9 && hMh_sigma <= 0)) {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return;
}
kalmanGain[0] = Mh[0] / hMh_sigma;
@@ -301,7 +301,7 @@
_lastUpdateT = now;
if (_alphaCount == 0) {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return;
}
double alpha =
diff --git a/modules/video_coding/nack_requester_unittest.cc b/modules/video_coding/nack_requester_unittest.cc
index c9659e3..0e5d415 100644
--- a/modules/video_coding/nack_requester_unittest.cc
+++ b/modules/video_coding/nack_requester_unittest.cc
@@ -56,7 +56,7 @@
bool WaitForSendNack() {
if (timed_out_) {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return false;
}
diff --git a/modules/video_coding/svc/scalability_structure_full_svc.cc b/modules/video_coding/svc/scalability_structure_full_svc.cc
index 7177427..8920592 100644
--- a/modules/video_coding/svc/scalability_structure_full_svc.cc
+++ b/modules/video_coding/svc/scalability_structure_full_svc.cc
@@ -123,7 +123,7 @@
}
return kDeltaT0;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return kNone;
}
@@ -227,7 +227,7 @@
}
break;
case kNone:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
diff --git a/modules/video_coding/svc/scalability_structure_key_svc.cc b/modules/video_coding/svc/scalability_structure_key_svc.cc
index 6cd96a6..0ef7e8f 100644
--- a/modules/video_coding/svc/scalability_structure_key_svc.cc
+++ b/modules/video_coding/svc/scalability_structure_key_svc.cc
@@ -198,7 +198,7 @@
}
return kDeltaT0;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return kNone;
}
@@ -227,7 +227,7 @@
case kNone:
break;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return {};
}
diff --git a/modules/video_coding/svc/scalability_structure_simulcast.cc b/modules/video_coding/svc/scalability_structure_simulcast.cc
index 0db91cc..e5fa4c4 100644
--- a/modules/video_coding/svc/scalability_structure_simulcast.cc
+++ b/modules/video_coding/svc/scalability_structure_simulcast.cc
@@ -106,7 +106,7 @@
}
return kDeltaT0;
}
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return kDeltaT0;
}
@@ -184,7 +184,7 @@
}
break;
case kNone:
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
break;
}
diff --git a/modules/video_coding/utility/simulcast_test_fixture_impl.cc b/modules/video_coding/utility/simulcast_test_fixture_impl.cc
index 435f472..0789f6a 100644
--- a/modules/video_coding/utility/simulcast_test_fixture_impl.cc
+++ b/modules/video_coding/utility/simulcast_test_fixture_impl.cc
@@ -143,7 +143,7 @@
return 0;
}
int32_t Decoded(VideoFrame& decoded_image, int64_t decode_time_ms) override {
- RTC_NOTREACHED();
+ RTC_DCHECK_NOTREACHED();
return -1;
}
void Decoded(VideoFrame& decoded_image,