commit d151cc6fa3130f2ae365417b53a52282b2527b50
author Mirko Bonadei <mbonadei@webrtc.org> Mon Jun 20 06:35:28 2022 +0000
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 22 10:44:51 2022 +0000
tree b3b03a4b4de02537690e7e5ff7f848f71a12869f
parent b32ff729c91beb93ed91f6d4fe0ee4f2fd0c75c7

Remove the last build cycle in WebRTC

This CL removes the last "nogncheck" comment that was related to a
known build cycle. The remaining ones are because of conditional
dependencies.

Bug: webrtc:8733
Change-Id: Ie6862ae1cc613b9c2740a34c3167e1741ed31ee3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265981
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37302}

api/BUILD.gn

diff --git a/api/BUILD.gn b/api/BUILD.gn
index cd1c104..6ce4321 100644
--- a/api/BUILD.gn
+++ b/api/BUILD.gn
@@ -134,15 +134,13 @@
   ]
 }
 
-# TODO(bugs.webrtc.org/8733): Switch to rtc_library.
 rtc_library("candidate") {
   visibility = [ "*" ]
 
-  # TODO(bugs.webrtc.org/8733): Uncomment.
-  # sources = [
-  #   "candidate.cc",
-  #   "candidate.h",
-  # ]
+  sources = [
+    "candidate.cc",
+    "candidate.h",
+  ]
   deps = [
     "../rtc_base",
     "../rtc_base:checks",
@@ -158,15 +156,13 @@
 
 rtc_source_set("turn_customizer") {
   visibility = [ "*" ]
-  # TODO(bugs.webrtc.org/8733): Uncomment.
-  # sources = [ "turn_customizer.h" ]
+  sources = [ "turn_customizer.h" ]
 }
 
 rtc_source_set("ice_transport_interface") {
   visibility = [ "*" ]
 
-  # TODO(bugs.webrtc.org/8733): Uncomment.
-  # sources = [ "ice_transport_interface.h" ]
+  sources = [ "ice_transport_interface.h" ]
   deps = [
     ":async_dns_resolver",
     ":packet_socket_factory",
@@ -177,15 +173,13 @@
   ]
 }
 
-# TODO(bugs.webrtc.org/8733): Switch to rtc_library.
-rtc_source_set("dtls_transport_interface") {
+rtc_library("dtls_transport_interface") {
   visibility = [ "*" ]
 
-  # TODO(bugs.webrtc.org/8733): Uncomment.
-  # sources = [
-  #   "dtls_transport_interface.cc",
-  #   "dtls_transport_interface.h",
-  # ]
+  sources = [
+    "dtls_transport_interface.cc",
+    "dtls_transport_interface.h",
+  ]
   deps = [
     ":ice_transport_interface",
     ":rtc_error",
@@ -201,15 +195,10 @@
   visibility = [ "*" ]
   cflags = []
   sources = [
-    "candidate.cc",
-    "candidate.h",
     "crypto_params.h",
     "data_channel_interface.cc",
     "data_channel_interface.h",
-    "dtls_transport_interface.cc",
-    "dtls_transport_interface.h",
     "dtmf_sender_interface.h",
-    "ice_transport_interface.h",
     "jsep.cc",
     "jsep.h",
     "jsep_ice_candidate.cc",
@@ -229,7 +218,6 @@
     "set_remote_description_observer_interface.h",
     "stats_types.cc",
     "stats_types.h",
-    "turn_customizer.h",
     "uma_metrics.h",
     "video_track_source_proxy_factory.h",
   ]
@@ -238,10 +226,13 @@
     ":async_dns_resolver",
     ":audio_options_api",
     ":callfactory_api",
+    ":candidate",
+    ":dtls_transport_interface",
     ":fec_controller_api",
     ":field_trials",
     ":field_trials_view",
     ":frame_transformer_interface",
+    ":ice_transport_interface",
     ":libjingle_logging_api",
     ":make_ref_counted",
     ":media_stream_interface",
@@ -255,7 +246,9 @@
     ":rtp_transceiver_direction",
     ":scoped_refptr",
     ":sequence_checker",
+    ":turn_customizer",
     "../call:rtp_interfaces",
+    "../p2p:rtc_p2p",
     "../rtc_base:copy_on_write_buffer",
     "../rtc_base:logging",
     "../rtc_base:network_constants",
@@ -839,6 +832,7 @@
     "ice_transport_factory.h",
   ]
   deps = [
+    ":ice_transport_interface",
     ":libjingle_peerconnection_api",
     ":make_ref_counted",
     ":packet_socket_factory",

api/peer_connection_interface.h

diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h
index 7e16ad9..54c4c46 100644
--- a/api/peer_connection_interface.h
+++ b/api/peer_connection_interface.h
@@ -125,8 +125,8 @@
 #include "media/base/media_engine.h"
 // TODO(bugs.webrtc.org/7447): We plan to provide a way to let applications
 // inject a PacketSocketFactory and/or NetworkManager, and not expose
-// PortAllocator in the PeerConnection api. This will let us remove nogncheck.
-#include "p2p/base/port_allocator.h"  // nogncheck
+// PortAllocator in the PeerConnection api.
+#include "p2p/base/port_allocator.h"
 #include "rtc_base/network.h"
 #include "rtc_base/network_constants.h"
 #include "rtc_base/network_monitor_factory.h"