commit cf9094a26e4370a80f220a315f6b57fd64f97156
author Yura Yaroshevich <yura.yaroshevich@gmail.com> Mon Mar 28 14:20:05 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 28 13:05:41 2022 +0000
tree 9e100d4d00cc7905c4bb514b81b6237b5b61163c
parent e0c6bdf07103e6c9aec89763ce91aec33b8d5241

[iOS] Fixed RTC_DCHECK_NOTREACHED

Bug: None
Change-Id: I93f716a1e9c1b08e2bc1dc96ad282e66ef0dfaf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256962
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/main@{#36354}

sdk/objc/api/logging/RTCCallbackLogger.mm

diff --git a/sdk/objc/api/logging/RTCCallbackLogger.mm b/sdk/objc/api/logging/RTCCallbackLogger.mm
index 90bb8b0..ba6fe1b 100644
--- a/sdk/objc/api/logging/RTCCallbackLogger.mm
+++ b/sdk/objc/api/logging/RTCCallbackLogger.mm
@@ -19,7 +19,9 @@
 #include "rtc_base/log_sinks.h"
 #include "rtc_base/logging.h"
 
-class CallbackLogSink : public rtc::LogSink {
+namespace {
+
+class CallbackLogSink final : public rtc::LogSink {
  public:
   CallbackLogSink(RTCCallbackLoggerMessageHandler callbackHandler)
       : callback_handler_(callbackHandler) {}
@@ -38,13 +40,17 @@
   RTCCallbackLoggerMessageHandler callback_handler_;
 };
 
-class CallbackWithSeverityLogSink : public rtc::LogSink {
+class CallbackWithSeverityLogSink final : public rtc::LogSink {
  public:
   CallbackWithSeverityLogSink(RTCCallbackLoggerMessageAndSeverityHandler callbackHandler)
       : callback_handler_(callbackHandler) {}
 
   void OnLogMessage(const std::string& message) override { RTC_DCHECK_NOTREACHED(); }
 
+  void OnLogMessage(const std::string& message, rtc::LoggingSeverity severity) override {
+    OnLogMessage(absl::string_view(message), severity);
+  }
+
   void OnLogMessage(absl::string_view message, rtc::LoggingSeverity severity) override {
     if (callback_handler_) {
       RTCLoggingSeverity loggingSeverity = NativeSeverityToObjcSeverity(severity);
@@ -71,6 +77,8 @@
   RTCCallbackLoggerMessageAndSeverityHandler callback_handler_;
 };
 
+}
+
 @implementation RTC_OBJC_TYPE (RTCCallbackLogger) {
   BOOL _hasStarted;
   std::unique_ptr<rtc::LogSink> _logSink;