commit cea7c2f7839eef81ecbd6dd10d103190ef68875c
author kwiberg <kwiberg@webrtc.org> Thu Jan 07 05:52:04 2016 -0800
committer Commit bot <commit-bot@chromium.org> Thu Jan 07 13:52:09 2016 +0000
tree 0029c3759cab287cb2d743f75d4f2007c3cfa26b
parent a46a4c92d0c74fab0028170d0746e2670160aefd

Replace manual casting to rvalue reference with calls to std::move

Review URL: https://codereview.webrtc.org/1570473002

Cr-Commit-Position: refs/heads/master@{#11163}

webrtc/base/optional_unittest.cc

diff --git a/webrtc/base/optional_unittest.cc b/webrtc/base/optional_unittest.cc
index 5483314..eabf091 100644
--- a/webrtc/base/optional_unittest.cc
+++ b/webrtc/base/optional_unittest.cc
@@ -162,7 +162,7 @@
   {
     Optional<Logger> x;
     EXPECT_FALSE(x);
-    auto y = static_cast<Optional<Logger>&&>(x);
+    auto y = std::move(x);
     EXPECT_FALSE(y);
   }
   EXPECT_EQ(V("0:0. default constructor", "1:0. move constructor (from 0:0)",
@@ -176,7 +176,7 @@
     Optional<Logger> x(Logger(17));
     EXPECT_TRUE(x);
     log->push_back("---");
-    auto y = static_cast<Optional<Logger>&&>(x);
+    auto y = std::move(x);
     EXPECT_TRUE(x);
     EXPECT_TRUE(y);
     log->push_back("---");
@@ -289,7 +289,7 @@
   auto log = Logger::Setup();
   {
     Optional<Logger> x, y;
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
   }
   EXPECT_EQ(
       V("0:0. default constructor", "1:1. default constructor",
@@ -303,7 +303,7 @@
     Optional<Logger> x(Logger(17));
     Optional<Logger> y;
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(
@@ -320,7 +320,7 @@
     Optional<Logger> x;
     Optional<Logger> y(Logger(17));
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(V("0:0. default constructor", "1:17. explicit constructor",
@@ -336,7 +336,7 @@
     Optional<Logger> x(Logger(17));
     Optional<Logger> y(Logger(42));
     log->push_back("---");
-    x = static_cast<Optional<Logger>&&>(y);
+    x = std::move(y);
     log->push_back("---");
   }
   EXPECT_EQ(
@@ -354,7 +354,7 @@
     Optional<Logger> x;
     Logger y(17);
     log->push_back("---");
-    x = Optional<Logger>(static_cast<Logger&&>(y));
+    x = Optional<Logger>(std::move(y));
     log->push_back("---");
   }
   EXPECT_EQ(V("0:0. default constructor", "1:17. explicit constructor", "---",
@@ -370,7 +370,7 @@
     Optional<Logger> x(Logger(17));
     Logger y(42);
     log->push_back("---");
-    x = Optional<Logger>(static_cast<Logger&&>(y));
+    x = Optional<Logger>(std::move(y));
     log->push_back("---");
   }
   EXPECT_EQ(
@@ -390,13 +390,13 @@
     log->push_back("---");
     x->Foo();
     y->Foo();
-    static_cast<Optional<Logger>&&>(x)->Foo();
-    static_cast<const Optional<Logger>&&>(y)->Foo();
+    std::move(x)->Foo();
+    std::move(y)->Foo();
     log->push_back("---");
     (*x).Foo();
     (*y).Foo();
-    (*static_cast<Optional<Logger>&&>(x)).Foo();
-    (*static_cast<const Optional<Logger>&&>(y)).Foo();
+    (*std::move(x)).Foo();
+    (*std::move(y)).Foo();
     log->push_back("---");
   }
   EXPECT_EQ(V("0:42. explicit constructor",