commit ce80886bf262e7a33f8a1f83a2dcf6f9274df39b
author Danil Chapovalov <danilchap@webrtc.org> Wed Jun 22 15:48:36 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 28 10:04:23 2022 +0000
tree 87245602195958841529c5441a24d48becd91673
parent e58f1991dc9ac6cb8dd4cd3601dbbb3ea312df3d

Remove video_coding dependency on ProcessThread and Module

Bug: webrtc:7219
Change-Id: I360f7df5554389274fcaef64070b9441ce0ef984
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266486
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37351}

modules/video_coding/video_coding_impl.h

diff --git a/modules/video_coding/video_coding_impl.h b/modules/video_coding/video_coding_impl.h
index c50cb17..22237ca 100644
--- a/modules/video_coding/video_coding_impl.h
+++ b/modules/video_coding/video_coding_impl.h
@@ -55,12 +55,12 @@
   int64_t _latestMs;
 };
 
-class VideoReceiver : public Module {
+class VideoReceiver {
  public:
   VideoReceiver(Clock* clock,
                 VCMTiming* timing,
                 const FieldTrialsView& field_trials);
-  ~VideoReceiver() override;
+  ~VideoReceiver();
 
   void RegisterReceiveCodec(uint8_t payload_type,
                             const VideoDecoder::Settings& settings);
@@ -82,9 +82,7 @@
                        int max_packet_age_to_nack,
                        int max_incomplete_time_ms);
 
-  int64_t TimeUntilNextProcess() override;
-  void Process() override;
-  void ProcessThreadAttached(ProcessThread* process_thread) override;
+  void Process();
 
  protected:
   int32_t Decode(const webrtc::VCMEncodedFrame& frame);
@@ -130,11 +128,6 @@
   VCMProcessTimer _keyRequestTimer RTC_GUARDED_BY(module_thread_checker_);
   ThreadUnsafeOneTimeEvent first_frame_received_
       RTC_GUARDED_BY(decoder_thread_checker_);
-  // Modified on the construction thread. Can be read without a lock and assumed
-  // to be non-null on the module and decoder threads.
-  ProcessThread* process_thread_ = nullptr;
-  bool is_attached_to_process_thread_
-      RTC_GUARDED_BY(construction_thread_checker_) = false;
 };
 
 }  // namespace vcm