Reformat GN files.
`gn format` recently [1] changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
CL generated with:
$ git ls-files | grep BUILD.gn | xargs gn format
$ gn format build_overrides/build.gni
$ gn format build_overrides/gtest.gni
$ gn format modules/audio_coding/audio_coding.gni
$ gn format webrtc.gni
$ gn format .gn
Plus a few manual changes to add exceptions for
"public_deps" (after changing these lines the presubmit
started to complain).
[1] - https://gn-review.googlesource.com/c/gn/+/6860
Bug: webrtc:11302
Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30334}
diff --git a/examples/BUILD.gn b/examples/BUILD.gn
index dbcd84b..4f76cad 100644
--- a/examples/BUILD.gn
+++ b/examples/BUILD.gn
@@ -66,17 +66,13 @@
"turnserver/read_auth_file.cc",
"turnserver/read_auth_file.h",
]
- deps = [
- "../rtc_base",
- ]
+ deps = [ "../rtc_base" ]
}
if (rtc_include_tests) {
rtc_test("examples_unittests") {
testonly = true
- sources = [
- "turnserver/read_auth_file_unittest.cc",
- ]
+ sources = [ "turnserver/read_auth_file_unittest.cc" ]
deps = [
":read_auth_file",
"../test:test_main",
@@ -199,13 +195,9 @@
if (is_ios) {
# iOS must use WebRTC.framework which is dynamically linked.
- deps = [
- "../sdk:framework_objc+link",
- ]
+ deps = [ "../sdk:framework_objc+link" ]
} else {
- deps = [
- "../sdk:mac_framework_objc+link",
- ]
+ deps = [ "../sdk:mac_framework_objc+link" ]
}
}
@@ -323,9 +315,7 @@
ios_app_bundle("AppRTCMobile") {
testonly = true
- sources = [
- "objc/AppRTCMobile/ios/main.m",
- ]
+ sources = [ "objc/AppRTCMobile/ios/main.m" ]
info_plist = "objc/AppRTCMobile/ios/Info.plist"
@@ -354,28 +344,16 @@
if (rtc_apprtcmobile_broadcast_extension) {
bundle_data("AppRTCMobileBroadcastUpload_extension_bundle") {
testonly = true
- public_deps = [
- ":AppRTCMobileBroadcastUpload",
- ]
- sources = [
- "$root_out_dir/AppRTCMobileBroadcastUpload.appex",
- ]
- outputs = [
- "{{bundle_contents_dir}}/Plugins/{{source_file_part}}",
- ]
+ public_deps = [ ":AppRTCMobileBroadcastUpload" ] # no-presubmit-check TODO(webrtc:8603)
+ sources = [ "$root_out_dir/AppRTCMobileBroadcastUpload.appex" ]
+ outputs = [ "{{bundle_contents_dir}}/Plugins/{{source_file_part}}" ]
}
bundle_data("AppRTCMobileBroadcastSetupUI_extension_bundle") {
testonly = true
- public_deps = [
- ":AppRTCMobileBroadcastSetupUI",
- ]
- sources = [
- "$root_out_dir/AppRTCMobileBroadcastSetupUI.appex",
- ]
- outputs = [
- "{{bundle_contents_dir}}/Plugins/{{source_file_part}}",
- ]
+ public_deps = [ ":AppRTCMobileBroadcastSetupUI" ] # no-presubmit-check TODO(webrtc:8603)
+ sources = [ "$root_out_dir/AppRTCMobileBroadcastSetupUI.appex" ]
+ outputs = [ "{{bundle_contents_dir}}/Plugins/{{source_file_part}}" ]
}
rtc_library("AppRTCMobileBroadcastUpload_lib") {
@@ -417,9 +395,7 @@
libs = [ "ReplayKit.framework" ]
- deps = [
- ":AppRTCMobile_ios_bundle_data",
- ]
+ deps = [ ":AppRTCMobile_ios_bundle_data" ]
}
}
@@ -447,9 +423,7 @@
"objc/Icon-180.png",
"objc/Icon.png",
]
- outputs = [
- "{{bundle_resources_dir}}/{{source_file_part}}",
- ]
+ outputs = [ "{{bundle_resources_dir}}/{{source_file_part}}" ]
}
rtc_library("ObjCNativeAPIDemo_lib") {
@@ -491,18 +465,14 @@
ios_app_bundle("ObjCNativeAPIDemo") {
testonly = true
- sources = [
- "objcnativeapi/objc/main.m",
- ]
+ sources = [ "objcnativeapi/objc/main.m" ]
info_plist = "objcnativeapi/Info.plist"
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
- deps = [
- ":ObjCNativeAPIDemo_lib",
- ]
+ deps = [ ":ObjCNativeAPIDemo_lib" ]
if (target_cpu == "x86") {
deps += [ "//testing/iossim" ]
@@ -531,9 +501,7 @@
testonly = true
output_name = "AppRTCMobile"
- sources = [
- "objc/AppRTCMobile/mac/main.m",
- ]
+ sources = [ "objc/AppRTCMobile/mac/main.m" ]
public_configs = [ "..:common_inherited_config" ]
@@ -619,9 +587,7 @@
rtc_ios_xctest_test("apprtcmobile_tests") {
info_plist = "objc/AppRTCMobile/ios/Info.plist"
- sources = [
- "objc/AppRTCMobile/tests/main.mm",
- ]
+ sources = [ "objc/AppRTCMobile/tests/main.mm" ]
deps = [
":AppRTCMobile_lib",
":apprtcmobile_test_sources",
@@ -741,9 +707,7 @@
}
rtc_executable("turnserver") {
testonly = true
- sources = [
- "turnserver/turnserver_main.cc",
- ]
+ sources = [ "turnserver/turnserver_main.cc" ]
deps = [
":read_auth_file",
"../p2p:p2p_server_utils",
@@ -755,9 +719,7 @@
}
rtc_executable("stunserver") {
testonly = true
- sources = [
- "stunserver/stunserver_main.cc",
- ]
+ sources = [ "stunserver/stunserver_main.cc" ]
deps = [
"../p2p:p2p_server_utils",
"../p2p:rtc_p2p",
@@ -826,9 +788,7 @@
if (is_android) {
rtc_android_library("webrtc_unity_java") {
- sources = [
- "unityplugin/java/src/org/webrtc/UnityUtility.java",
- ]
+ sources = [ "unityplugin/java/src/org/webrtc/UnityUtility.java" ]
deps = [
"../rtc_base:base_java",
"../sdk/android:camera_java",
@@ -879,9 +839,7 @@
# Doesn't build within Chrome on Win.
rtc_executable("stun_prober") {
testonly = true
- sources = [
- "stunprober/main.cc",
- ]
+ sources = [ "stunprober/main.cc" ]
deps = [
"../p2p:libstunprober",
"../p2p:rtc_p2p",
diff --git a/examples/androidnativeapi/BUILD.gn b/examples/androidnativeapi/BUILD.gn
index a5ad414..9dd2bf4 100644
--- a/examples/androidnativeapi/BUILD.gn
+++ b/examples/androidnativeapi/BUILD.gn
@@ -28,9 +28,7 @@
generate_jni("generated_jni") {
testonly = true
- sources = [
- "java/org/webrtc/examples/androidnativeapi/CallClient.java",
- ]
+ sources = [ "java/org/webrtc/examples/androidnativeapi/CallClient.java" ]
namespace = "webrtc_examples"
jni_generator_include = "//sdk/android/src/jni/jni_generator_helper.h"
}