Introduce RTC_CHECK_NOTREACHED(), an always-checking RTC_NOTREACHED()
And use it in a few places that were using RTC_CHECK(false) or FATAL()
to do the exact same job. There should be no change in behavior.
Bug: none
Change-Id: I36d5e6bcf35fd41534e08a8c879fa0811b4f1967
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191963
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32567}
diff --git a/api/adaptation/resource.cc b/api/adaptation/resource.cc
index c6a7e32..dac03fe 100644
--- a/api/adaptation/resource.cc
+++ b/api/adaptation/resource.cc
@@ -21,7 +21,7 @@
case ResourceUsageState::kUnderuse:
return "kUnderuse";
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
ResourceListener::~ResourceListener() {}
diff --git a/api/audio_codecs/ilbc/audio_encoder_ilbc.cc b/api/audio_codecs/ilbc/audio_encoder_ilbc.cc
index bd653b7..035b0dc 100644
--- a/api/audio_codecs/ilbc/audio_encoder_ilbc.cc
+++ b/api/audio_codecs/ilbc/audio_encoder_ilbc.cc
@@ -32,7 +32,7 @@
// 50 bytes per frame of 30 ms => (approx) 13333 bits/s.
return 13333;
default:
- FATAL();
+ RTC_CHECK_NOTREACHED();
}
}
} // namespace
diff --git a/api/media_types.cc b/api/media_types.cc
index 4ab80ed..3453ce3 100644
--- a/api/media_types.cc
+++ b/api/media_types.cc
@@ -31,7 +31,7 @@
RTC_NOTREACHED();
return "";
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
} // namespace cricket
diff --git a/api/rtp_parameters.cc b/api/rtp_parameters.cc
index f22ed67..92f99e9 100644
--- a/api/rtp_parameters.cc
+++ b/api/rtp_parameters.cc
@@ -30,7 +30,7 @@
case DegradationPreference::BALANCED:
return "balanced";
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
const double kDefaultBitratePriority = 1.0;
diff --git a/api/test/dummy_peer_connection.h b/api/test/dummy_peer_connection.h
index 0ca7d3f..4d17aed 100644
--- a/api/test/dummy_peer_connection.h
+++ b/api/test/dummy_peer_connection.h
@@ -36,7 +36,7 @@
bool AddStream(MediaStreamInterface* stream) override { return false; }
void RemoveStream(MediaStreamInterface* stream) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
RTCErrorOr<rtc::scoped_refptr<RtpSenderInterface>> AddTrack(
@@ -100,17 +100,17 @@
}
void GetStats(RTCStatsCollectorCallback* callback) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void GetStats(
rtc::scoped_refptr<RtpSenderInterface> selector,
rtc::scoped_refptr<RTCStatsCollectorCallback> callback) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void GetStats(
rtc::scoped_refptr<RtpReceiverInterface> selector,
rtc::scoped_refptr<RTCStatsCollectorCallback> callback) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void ClearStatsCache() override {}
@@ -145,33 +145,33 @@
return nullptr;
}
- void RestartIce() override { FATAL() << "Not implemented"; }
+ void RestartIce() override { RTC_CHECK_NOTREACHED(); }
// Create a new offer.
// The CreateSessionDescriptionObserver callback will be called when done.
void CreateOffer(CreateSessionDescriptionObserver* observer,
const RTCOfferAnswerOptions& options) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void CreateAnswer(CreateSessionDescriptionObserver* observer,
const RTCOfferAnswerOptions& options) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void SetLocalDescription(SetSessionDescriptionObserver* observer,
SessionDescriptionInterface* desc) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void SetRemoteDescription(SetSessionDescriptionObserver* observer,
SessionDescriptionInterface* desc) override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
void SetRemoteDescription(
std::unique_ptr<SessionDescriptionInterface> desc,
rtc::scoped_refptr<SetRemoteDescriptionObserverInterface> observer)
override {
- FATAL() << "Not implemented";
+ RTC_CHECK_NOTREACHED();
}
PeerConnectionInterface::RTCConfiguration GetConfiguration() override {
@@ -194,10 +194,8 @@
return RTCError(RTCErrorType::UNSUPPORTED_OPERATION, "Not implemented");
}
- void SetAudioPlayout(bool playout) override { FATAL() << "Not implemented"; }
- void SetAudioRecording(bool recording) override {
- FATAL() << "Not implemented";
- }
+ void SetAudioPlayout(bool playout) override { RTC_CHECK_NOTREACHED(); }
+ void SetAudioRecording(bool recording) override { RTC_CHECK_NOTREACHED(); }
rtc::scoped_refptr<DtlsTransportInterface> LookupDtlsTransportByMid(
const std::string& mid) override {
@@ -235,7 +233,7 @@
return false;
}
- void StopRtcEventLog() { FATAL() << "Not implemented"; }
+ void StopRtcEventLog() { RTC_CHECK_NOTREACHED(); }
void Close() override {}
diff --git a/api/video_codecs/video_codec.cc b/api/video_codecs/video_codec.cc
index ecc5699..d05eb45 100644
--- a/api/video_codecs/video_codec.cc
+++ b/api/video_codecs/video_codec.cc
@@ -120,7 +120,7 @@
case kVideoCodecGeneric:
return kPayloadNameGeneric;
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
VideoCodecType PayloadStringToCodecType(const std::string& name) {
diff --git a/api/video_codecs/video_encoder_software_fallback_wrapper.cc b/api/video_codecs/video_encoder_software_fallback_wrapper.cc
index bb97d30..95a41d0 100644
--- a/api/video_codecs/video_encoder_software_fallback_wrapper.cc
+++ b/api/video_codecs/video_encoder_software_fallback_wrapper.cc
@@ -162,7 +162,7 @@
case EncoderState::kForcedFallback:
return fallback_encoder_.get();
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
// Updates encoder with last observed parameters, such as callbacks, rates,
@@ -346,7 +346,7 @@
case EncoderState::kForcedFallback:
return fallback_encoder_->Encode(frame, frame_types);
}
- RTC_CHECK(false);
+ RTC_CHECK_NOTREACHED();
}
int32_t VideoEncoderSoftwareFallbackWrapper::EncodeWithMainEncoder(