Remove objc tests from rtc_unittests and move tests to sdk_unittests
The tests in rtc_unittests_objc are old gtest based tests and
The tests in sdk_unittests are XCTest based tests.
The objc tests in rtc_unittest are causing problems [1],
so I think it's time to combine the two types of objc tests.
Renaming the files to match the existing sdk_unittests and
removing the use of gtest helper functions (eg, EXPECT_EQ)
are planned for follow-up CLs.
[1] https://webrtc-review.googlesource.com/c/src/+/261724/9
Bug: webrtc:8382
Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36878}
diff --git a/sdk/objc/unittests/RTCSessionDescriptionTest.mm b/sdk/objc/unittests/RTCSessionDescriptionTest.mm
index cb4a01c..70c82f7 100644
--- a/sdk/objc/unittests/RTCSessionDescriptionTest.mm
+++ b/sdk/objc/unittests/RTCSessionDescriptionTest.mm
@@ -9,6 +9,7 @@
*/
#import <Foundation/Foundation.h>
+#import <XCTest/XCTest.h>
#include "rtc_base/gunit.h"
@@ -16,12 +17,10 @@
#import "api/peerconnection/RTCSessionDescription.h"
#import "helpers/NSString+StdString.h"
-@interface RTCSessionDescriptionTest : NSObject
-- (void)testSessionDescriptionConversion;
-- (void)testInitFromNativeSessionDescription;
+@interface RTCSessionDescriptionTests : XCTestCase
@end
-@implementation RTCSessionDescriptionTest
+@implementation RTCSessionDescriptionTests
/**
* Test conversion of an Objective-C RTC_OBJC_TYPE(RTCSessionDescription) to a native
@@ -121,17 +120,3 @@
}
@end
-
-TEST(RTCSessionDescriptionTest, SessionDescriptionConversionTest) {
- @autoreleasepool {
- RTCSessionDescriptionTest *test = [[RTCSessionDescriptionTest alloc] init];
- [test testSessionDescriptionConversion];
- }
-}
-
-TEST(RTCSessionDescriptionTest, InitFromSessionDescriptionTest) {
- @autoreleasepool {
- RTCSessionDescriptionTest *test = [[RTCSessionDescriptionTest alloc] init];
- [test testInitFromNativeSessionDescription];
- }
-}