Remove objc tests from rtc_unittests and move tests to sdk_unittests
The tests in rtc_unittests_objc are old gtest based tests and
The tests in sdk_unittests are XCTest based tests.
The objc tests in rtc_unittest are causing problems [1],
so I think it's time to combine the two types of objc tests.
Renaming the files to match the existing sdk_unittests and
removing the use of gtest helper functions (eg, EXPECT_EQ)
are planned for follow-up CLs.
[1] https://webrtc-review.googlesource.com/c/src/+/261724/9
Bug: webrtc:8382
Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36878}
diff --git a/sdk/objc/unittests/RTCPeerConnectionTest.mm b/sdk/objc/unittests/RTCPeerConnectionTest.mm
index 8ebe627..9ca8403 100644
--- a/sdk/objc/unittests/RTCPeerConnectionTest.mm
+++ b/sdk/objc/unittests/RTCPeerConnectionTest.mm
@@ -9,6 +9,7 @@
*/
#import <Foundation/Foundation.h>
+#import <XCTest/XCTest.h>
#include <memory>
#include <vector>
@@ -27,14 +28,10 @@
#import "api/peerconnection/RTCSessionDescription.h"
#import "helpers/NSString+StdString.h"
-@interface RTCPeerConnectionTest : NSObject
-- (void)testConfigurationGetter;
-- (void)testWithDependencies;
-- (void)testWithInvalidSDP;
-- (void)testWithInvalidIceCandidate;
+@interface RTCPeerConnectionTests : XCTestCase
@end
-@implementation RTCPeerConnectionTest
+@implementation RTCPeerConnectionTests
- (void)testConfigurationGetter {
NSArray *urlStrings = @[ @"stun:stun1.example.net" ];
@@ -205,31 +202,3 @@
}
@end
-
-TEST(RTCPeerConnectionTest, ConfigurationGetterTest) {
- @autoreleasepool {
- RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
- [test testConfigurationGetter];
- }
-}
-
-TEST(RTCPeerConnectionTest, TestWithDependencies) {
- @autoreleasepool {
- RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
- [test testWithDependencies];
- }
-}
-
-TEST(RTCPeerConnectionTest, TestWithInvalidSDP) {
- @autoreleasepool {
- RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
- [test testWithInvalidSDP];
- }
-}
-
-TEST(RTCPeerConnectionTest, TestWithInvalidIceCandidate) {
- @autoreleasepool {
- RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
- [test testWithInvalidIceCandidate];
- }
-}