Refactor the PlatformThread API.
PlatformThread's API is using old style function pointers, causes
casting, is unintuitive and forces artificial call sequences, and
is additionally possible to misuse in release mode.
Fix this by an API face lift:
1. The class is turned into a handle, which can be empty.
2. The only way of getting a non-empty PlatformThread is by calling
SpawnJoinable or SpawnDetached, clearly conveying the semantics to the
code reader.
3. Handles can be Finalized, which works differently for joinable and
detached threads:
a) Handles for detached threads are simply closed where applicable.
b) Joinable threads are joined before handles are closed.
4. The destructor finalizes handles. No explicit call is needed.
Fixed: webrtc:12727
Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33923}
diff --git a/rtc_base/logging_unittest.cc b/rtc_base/logging_unittest.cc
index 225d66d..dc1208f 100644
--- a/rtc_base/logging_unittest.cc
+++ b/rtc_base/logging_unittest.cc
@@ -160,18 +160,13 @@
class LogThread {
public:
- LogThread() : thread_(&ThreadEntry, this, "LogThread") {}
- ~LogThread() { thread_.Stop(); }
-
- void Start() { thread_.Start(); }
+ void Start() {
+ thread_ = PlatformThread::SpawnJoinable(
+ [] { RTC_LOG(LS_VERBOSE) << "RTC_LOG"; }, "LogThread");
+ }
private:
- void Run() { RTC_LOG(LS_VERBOSE) << "RTC_LOG"; }
-
- static void ThreadEntry(void* p) { static_cast<LogThread*>(p)->Run(); }
-
PlatformThread thread_;
- Event event_;
};
// Ensure we don't crash when adding/removing streams while threads are going.