| commit | c88b5d56ada5690ae352062e69a9f984a07d228c | [log] [tgz] |
|---|---|---|
| author | kjellander <kjellander@webrtc.org> | Wed Apr 05 06:42:43 2017 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Apr 05 13:42:43 2017 +0000 |
| tree | acdf2f6e4d73e173549a9b652d5987971874c21c | |
| parent | adf0635ed54f5c7b87c8d2ee774f2a5bbf6f1828 [diff] [blame] |
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of https://codereview.webrtc.org/2737233003/ ) Reason for revert: Fixing errors for reland. I have tested that this does not make Chromium video quality tests fail. Original issue's description: > Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ ) > > Reason for revert: > Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568 > I should have looked more closer at those :( > > Original issue's description: > > PyLint fixes for tools-webrtc and webrtc/tools > > > > Fix a lot of errors before bringing in the new config in > > https://codereview.webrtc.org/2737963003/ > > > > BUG=webrtc:7303 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2736233003 > > Cr-Commit-Position: refs/heads/master@{#17137} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c > > TBR=oprypin@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7303 > > Review-Url: https://codereview.webrtc.org/2737233003 > Cr-Commit-Position: refs/heads/master@{#17142} > Committed: https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc NOTRY=true BUG=webrtc:7312 Review-Url: https://codereview.webrtc.org/2741733003 Cr-Commit-Position: refs/heads/master@{#17541}
diff --git a/tools-webrtc/gn_check_autofix.py b/tools-webrtc/gn_check_autofix.py index 8a79cde..3c1b367 100644 --- a/tools-webrtc/gn_check_autofix.py +++ b/tools-webrtc/gn_check_autofix.py
@@ -43,7 +43,7 @@ def __enter__(self): return self._name - def __exit__(self, exc, value, tb): + def __exit__(self, exc, value, _tb): if self._name and not self._closed: shutil.rmtree(self._name) self._closed = True