commit c7a6569713699df07e3a717778014bcc8eff97b3
author pbos <pbos@webrtc.org> Fri May 06 12:50:04 2016 -0700
committer Commit bot <commit-bot@chromium.org> Fri May 06 19:50:08 2016 +0000
tree e12c9ccd5f6aacad56ddeba1dfa914b76472fcf5
parent 82d7862fe736f851ea1cf28e8b2ce9fa6be37e45

Revert of Disable failing modules_unittests for UBSan. (patchset #1 id:40001 of https://codereview.webrtc.org/1915813002/ )

Reason for revert:
Fix upstream should've landed in our repository.

Original issue's description:
> Disable failing modules_unittests for UBSan.
>
> BUG=webrtc:5820
> TBR=pbos@webrtc.org
>
> Committed: https://crrev.com/c23bf2e54d922486254cdd7657aafceaa958ce25
> Cr-Commit-Position: refs/heads/master@{#12482}

TBR=kjellander@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5820

Review-Url: https://codereview.webrtc.org/1937153002
Cr-Commit-Position: refs/heads/master@{#12647}

webrtc/modules/audio_processing/audio_processing_unittest.cc

diff --git a/webrtc/modules/audio_processing/audio_processing_unittest.cc b/webrtc/modules/audio_processing/audio_processing_unittest.cc
index a5b293e..ded75c8 100644
--- a/webrtc/modules/audio_processing/audio_processing_unittest.cc
+++ b/webrtc/modules/audio_processing/audio_processing_unittest.cc
@@ -1847,35 +1847,17 @@
   remove(limited_filename.c_str());
 }
 
-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
-#ifdef UNDEFINED_SANITIZER
-#define MAYBE_VerifyDebugDumpInt DISABLED_VerifyDebugDumpInt
-#else
-#define MAYBE_VerifyDebugDumpInt VerifyDebugDumpInt
-#endif
-TEST_F(ApmTest, MAYBE_VerifyDebugDumpInt) {
+TEST_F(ApmTest, VerifyDebugDumpInt) {
   VerifyDebugDumpTest(kIntFormat);
 }
 
-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
-#ifdef UNDEFINED_SANITIZER
-#define MAYBE_VerifyDebugDumpFloat DISABLED_VerifyDebugDumpFloat
-#else
-#define MAYBE_VerifyDebugDumpFloat VerifyDebugDumpFloat
-#endif
-TEST_F(ApmTest, MAYBE_VerifyDebugDumpFloat) {
+TEST_F(ApmTest, VerifyDebugDumpFloat) {
   VerifyDebugDumpTest(kFloatFormat);
 }
 #endif
 
 // TODO(andrew): expand test to verify output.
-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
-#ifdef UNDEFINED_SANITIZER
-#define MAYBE_DebugDump DISABLED_DebugDump
-#else
-#define MAYBE_DebugDump DebugDump
-#endif
-TEST_F(ApmTest, MAYBE_DebugDump) {
+TEST_F(ApmTest, DebugDump) {
   const std::string filename =
       test::TempFilename(test::OutputPath(), "debug_aec");
   EXPECT_EQ(apm_->kNullPointerError,
@@ -1908,13 +1890,7 @@
 }
 
 // TODO(andrew): expand test to verify output.
-// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
-#ifdef UNDEFINED_SANITIZER
-#define MAYBE_DebugDumpFromFileHandle DISABLED_DebugDumpFromFileHandle
-#else
-#define MAYBE_DebugDumpFromFileHandle DebugDumpFromFileHandle
-#endif
-TEST_F(ApmTest, MAYBE_DebugDumpFromFileHandle) {
+TEST_F(ApmTest, DebugDumpFromFileHandle) {
   FILE* fid = NULL;
   EXPECT_EQ(apm_->kNullPointerError, apm_->StartDebugRecording(fid, -1));
   const std::string filename =