commit bfd343b9bee8fe54ca862da5f66450cf08ca0348
author Johannes Kron <kron@webrtc.org> Mon Jul 01 10:07:50 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Tue Jul 02 08:28:06 2019 +0000
tree 4d0910354ac4ca5ead06cf5e2df0a766fec104d9
parent 419aae2ed3313e215f2b7dafe5a40e3f0f798298

Add totalDecodeTime to RTCInboundRTPStreamStats

Pull request to WebRTC stats specification:
https://github.com/w3c/webrtc-stats/pull/450

Bug: webrtc:10775
Change-Id: Id032cb324724329fee284ebc84595b9c39208ab8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144035
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28440}

modules/video_coding/include/video_coding_defines.h

diff --git a/modules/video_coding/include/video_coding_defines.h b/modules/video_coding/include/video_coding_defines.h
index b785734..043d8c6 100644
--- a/modules/video_coding/include/video_coding_defines.h
+++ b/modules/video_coding/include/video_coding_defines.h
@@ -51,9 +51,21 @@
 // rendered.
 class VCMReceiveCallback {
  public:
+  // TODO(kron): Remove once downstream projects are updated.
   virtual int32_t FrameToRender(VideoFrame& videoFrame,  // NOLINT
                                 absl::optional<uint8_t> qp,
-                                VideoContentType content_type) = 0;
+                                VideoContentType content_type) {
+    // Cannot be pure virtual since this should be removed from derived
+    // classes.
+    return FrameToRender(videoFrame, qp, 0, content_type);
+  }
+
+  virtual int32_t FrameToRender(VideoFrame& videoFrame,  // NOLINT
+                                absl::optional<uint8_t> qp,
+                                int32_t decode_time_ms,
+                                VideoContentType content_type) {
+    return FrameToRender(videoFrame, qp, content_type);
+  }
 
   // Called when the current receive codec changes.
   virtual void OnIncomingPayloadType(int payload_type);
@@ -71,8 +83,7 @@
                                size_t size_bytes,
                                VideoContentType content_type) = 0;
 
-  virtual void OnFrameBufferTimingsUpdated(int decode_ms,
-                                           int max_decode_ms,
+  virtual void OnFrameBufferTimingsUpdated(int max_decode_ms,
                                            int current_delay_ms,
                                            int target_delay_ms,
                                            int jitter_buffer_ms,