commit | be7e9c6047185afea06f6e324ee88dc7cc1f9b59 | [log] [tgz] |
---|---|---|
author | deadbeef <deadbeef@webrtc.org> | Tue Jul 11 20:07:37 2017 -0700 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jul 12 03:07:37 2017 +0000 |
tree | d8227aa74fce32194ef15d2713b5f9da14504b1c | |
parent | 13790bec6b76753c437acd95d7dc92f820a2ef12 [diff] [blame] |
Reland of Make "set_ignore_non_default_routes" actually use its argument. (patchset #1 id:1 of https://codereview.webrtc.org/2974193002/ ) Reason for revert: Wasn't actually the source of the memcheck issue, so relanding. Original issue's description: > Revert of Make "set_ignore_non_default_routes" actually use its argument. (patchset #1 id:1 of https://codereview.webrtc.org/2974873002/ ) > > Reason for revert: > Breaks Linux memcheck bot. > https://bugs.chromium.org/p/webrtc/issues/detail?id=7973 > > Original issue's description: > > Make "set_ignore_non_default_routes" actually use its argument. > > > > It takes a bool argument, but unconditionally sets the flag to "true". > > Since no comment is left to offer an explanation, I'm assuming this was > > an accident. > > > > BUG=webrtc:7716 > > TBR=pthatcher@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2974873002 > > Cr-Commit-Position: refs/heads/master@{#18959} > > Committed: https://chromium.googlesource.com/external/webrtc/+/05314c3252ec4eea20c91c41d82e3eb06c0a91db > > TBR=pthatcher@webrtc.org,pthatcher@google.com,deadbeef@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7716 > > Review-Url: https://codereview.webrtc.org/2974193002 > Cr-Commit-Position: refs/heads/master@{#18964} > Committed: https://chromium.googlesource.com/external/webrtc/+/1e50748d47357b61fdd8e25375f7dfd510832791 TBR=pthatcher@webrtc.org,pthatcher@google.com,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7716 Review-Url: https://codereview.webrtc.org/2979803002 Cr-Commit-Position: refs/heads/master@{#18982}
diff --git a/webrtc/rtc_base/network.h b/webrtc/rtc_base/network.h index 6f820bb..4cbbfef 100644 --- a/webrtc/rtc_base/network.h +++ b/webrtc/rtc_base/network.h
@@ -230,8 +230,9 @@ #if defined(WEBRTC_LINUX) // Sets the flag for ignoring non-default routes. + // Defaults to false. void set_ignore_non_default_routes(bool value) { - ignore_non_default_routes_ = true; + ignore_non_default_routes_ = value; } #endif