Restrict the 1-argument ArrayView constructor to types with .size() and .data()
Before this change, the argument still needed those methods, but not
having them resulted in a compilation error. Now, it results in this
constructor being removed from the overload set.
This currently makes no difference, but I'm about to publish a CL that
breaks without this.
Review-Url: https://codereview.webrtc.org/2312473002
Cr-Commit-Position: refs/heads/master@{#14068}
diff --git a/webrtc/base/array_view_unittest.cc b/webrtc/base/array_view_unittest.cc
index 8bb1bcc..9d5e1af 100644
--- a/webrtc/base/array_view_unittest.cc
+++ b/webrtc/base/array_view_unittest.cc
@@ -20,8 +20,45 @@
namespace rtc {
namespace {
+
+namespace test_has_data_and_size {
+
+template <typename C, typename T>
+using DS = internal::HasDataAndSize<C, T>;
+
+template <typename DR, typename SR>
+struct Test1 {
+ DR data();
+ SR size();
+};
+static_assert(DS<Test1<int*, int>, int>::value, "");
+static_assert(DS<Test1<int*, int>, const int>::value, "");
+static_assert(DS<Test1<const int*, int>, const int>::value, "");
+static_assert(!DS<Test1<const int*, int>, int>::value, ""); // Wrong const.
+static_assert(!DS<Test1<char*, size_t>, int>::value, ""); // Wrong ptr type.
+
+struct Test2 {
+ int* data;
+ size_t size;
+};
+static_assert(!DS<Test2, int>::value, ""); // Because they aren't methods.
+
+struct Test3 {
+ int* data();
+};
+static_assert(!DS<Test3, int>::value, ""); // Because .size() is missing.
+
+class Test4 {
+ int* data();
+ size_t size();
+};
+static_assert(!DS<Test4, int>::value, ""); // Because methods are private.
+
+} // namespace test_has_data_and_size
+
template <typename T>
void Call(ArrayView<T>) {}
+
} // namespace
TEST(ArrayViewTest, TestConstructFromPtrAndArray) {