Move check for number_of_cores parameter validitity
from runtime check in proxy classes that picks decoder (VCMDecoderDataBase)
to a DCHECK in the VideoDecoder::Settings
Bug: None
Change-Id: Ic8c2e971486a3a7eb247f9d03815aba5ca5a7bad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228644
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34761}
diff --git a/modules/video_coding/video_coding_impl.cc b/modules/video_coding/video_coding_impl.cc
index 6f4903e..95a5d6b 100644
--- a/modules/video_coding/video_coding_impl.cc
+++ b/modules/video_coding/video_coding_impl.cc
@@ -56,10 +56,10 @@
void Process() override { receiver_.Process(); }
- bool RegisterReceiveCodec(
+ void RegisterReceiveCodec(
uint8_t payload_type,
const VideoDecoder::Settings& decoder_settings) override {
- return receiver_.RegisterReceiveCodec(payload_type, decoder_settings);
+ receiver_.RegisterReceiveCodec(payload_type, decoder_settings);
}
int32_t RegisterReceiveCodec(uint8_t payload_type,
@@ -73,8 +73,8 @@
decoder_settings.set_buffer_pool_size(receive_codec->buffer_pool_size);
}
decoder_settings.set_number_of_cores(number_of_cores);
- return receiver_.RegisterReceiveCodec(payload_type, decoder_settings) ? 0
- : -1;
+ receiver_.RegisterReceiveCodec(payload_type, decoder_settings);
+ return 0;
}
void RegisterExternalDecoder(VideoDecoder* externalDecoder,