commit ba0a306585332141170d91856214b4386f264183
author Danil Chapovalov <danilchap@webrtc.org> Fri Aug 13 18:15:55 2021 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Aug 14 11:51:53 2021 +0000
tree d007c263f2dcb2b75a03780b444939cee27960f8
parent 10ee27e80f895d40822df3b0eb66b4608084acdd

Move check for number_of_cores parameter validitity

from runtime check in proxy classes that picks decoder (VCMDecoderDataBase)
to a DCHECK in the VideoDecoder::Settings

Bug: None
Change-Id: Ic8c2e971486a3a7eb247f9d03815aba5ca5a7bad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228644
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34761}

modules/video_coding/include/video_coding.h

diff --git a/modules/video_coding/include/video_coding.h b/modules/video_coding/include/video_coding.h
index b54b7e4..981bc74 100644
--- a/modules/video_coding/include/video_coding.h
+++ b/modules/video_coding/include/video_coding.h
@@ -46,9 +46,7 @@
   //      - payload_type      : RTP payload type
   //      - settings          : Settings for the decoder to be registered.
   //
-  // Return value      : true,  on success.
-  //                     false, on error.
-  virtual bool RegisterReceiveCodec(uint8_t payload_type,
+  virtual void RegisterReceiveCodec(uint8_t payload_type,
                                     const VideoDecoder::Settings& settings) = 0;
   ABSL_DEPRECATED("Use RegisterReceiveCodec above")
   virtual int32_t RegisterReceiveCodec(uint8_t payload_type,