commit ba0a306585332141170d91856214b4386f264183
author Danil Chapovalov <danilchap@webrtc.org> Fri Aug 13 18:15:55 2021 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Aug 14 11:51:53 2021 +0000
tree d007c263f2dcb2b75a03780b444939cee27960f8
parent 10ee27e80f895d40822df3b0eb66b4608084acdd

Move check for number_of_cores parameter validitity

from runtime check in proxy classes that picks decoder (VCMDecoderDataBase)
to a DCHECK in the VideoDecoder::Settings

Bug: None
Change-Id: Ic8c2e971486a3a7eb247f9d03815aba5ca5a7bad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228644
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34761}

modules/video_coding/decoder_database.cc

diff --git a/modules/video_coding/decoder_database.cc b/modules/video_coding/decoder_database.cc
index 467e99c..01120dc 100644
--- a/modules/video_coding/decoder_database.cc
+++ b/modules/video_coding/decoder_database.cc
@@ -48,18 +48,14 @@
          decoders_.find(payload_type) != decoders_.end();
 }
 
-bool VCMDecoderDataBase::RegisterReceiveCodec(
+void VCMDecoderDataBase::RegisterReceiveCodec(
     uint8_t payload_type,
     const VideoDecoder::Settings& settings) {
-  if (settings.number_of_cores() < 0) {
-    return false;
-  }
   // If payload value already exists, erase old and insert new.
   if (payload_type == current_payload_type_) {
     current_payload_type_ = absl::nullopt;
   }
   decoder_settings_[payload_type] = settings;
-  return true;
 }
 
 bool VCMDecoderDataBase::DeregisterReceiveCodec(uint8_t payload_type) {