commit b7821cea6bcd1ed1d0a49413c852429b208aeb5c
author Ali Tofigh <alito@webrtc.org> Tue Jul 12 16:08:13 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 12 22:09:36 2022 +0000
tree 8b6e32ac949a1c5caafa2b2f81a55d09f58e3402
parent c8f9c56bc8ac6d8af899d5d6cdd0fd95c2ead96d

Remove unnecessary overload in RtcEventLogOutput

Bug: webrtc:13579
Change-Id: I3ea4b8ce8d111ae6b9ce7e92f75bd4196bc9656b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268420
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37508}

api/rtc_event_log_output.h

diff --git a/api/rtc_event_log_output.h b/api/rtc_event_log_output.h
index ae61de6..f1f84a5 100644
--- a/api/rtc_event_log_output.h
+++ b/api/rtc_event_log_output.h
@@ -33,11 +33,6 @@
   // about how much data was written, if any. The output sink becomes inactive
   // after the first time `false` is returned. Write() may not be called on
   // an inactive output sink.
-  virtual bool Write(const std::string& output) {
-    return Write(absl::string_view(output));
-  }
-  // TODO(bugs.webrtc.org/13579): Remove the string ref once all classes
-  // implement the string_view version.
   virtual bool Write(absl::string_view output) = 0;
 
   // Indicates that buffers should be written to disk if applicable.

api/rtc_event_log_output_file_unittest.cc

diff --git a/api/rtc_event_log_output_file_unittest.cc b/api/rtc_event_log_output_file_unittest.cc
index ef5c3e6..0aff57f 100644
--- a/api/rtc_event_log_output_file_unittest.cc
+++ b/api/rtc_event_log_output_file_unittest.cc
@@ -78,9 +78,9 @@
   auto output_file =
       std::make_unique<RtcEventLogOutputFile>(output_file_name_, 2);
 
-  output_file->Write(absl::string_view("1"));
-  output_file->Write(absl::string_view("2"));
-  output_file->Write(absl::string_view("3"));
+  output_file->Write("1");
+  output_file->Write("2");
+  output_file->Write("3");
   // Unsuccessful writes close the file; no need to delete the output to flush.
 
   EXPECT_EQ(GetOutputFileContents(), "12");
@@ -108,20 +108,20 @@
 TEST_F(RtcEventLogOutputFileTest, UnsuccessfulWriteReturnsFalse) {
   auto output_file =
       std::make_unique<RtcEventLogOutputFile>(output_file_name_, 2);
-  EXPECT_FALSE(output_file->Write(absl::string_view("abc")));
+  EXPECT_FALSE(output_file->Write("abc"));
 }
 
 TEST_F(RtcEventLogOutputFileTest, SuccessfulWriteReturnsTrue) {
   auto output_file =
       std::make_unique<RtcEventLogOutputFile>(output_file_name_, 3);
-  EXPECT_TRUE(output_file->Write(absl::string_view("abc")));
+  EXPECT_TRUE(output_file->Write("abc"));
 }
 
 // Even if capacity is reached, a successful write leaves the output active.
 TEST_F(RtcEventLogOutputFileTest, FileStillActiveAfterSuccessfulWrite) {
   auto output_file =
       std::make_unique<RtcEventLogOutputFile>(output_file_name_, 3);
-  ASSERT_TRUE(output_file->Write(absl::string_view("abc")));
+  ASSERT_TRUE(output_file->Write("abc"));
   EXPECT_TRUE(output_file->IsActive());
 }
 
@@ -130,7 +130,7 @@
 TEST_F(RtcEventLogOutputFileTest, FileInactiveAfterUnsuccessfulWrite) {
   auto output_file =
       std::make_unique<RtcEventLogOutputFile>(output_file_name_, 2);
-  ASSERT_FALSE(output_file->Write(absl::string_view("abc")));
+  ASSERT_FALSE(output_file->Write("abc"));
   EXPECT_FALSE(output_file->IsActive());
 }
 
@@ -145,9 +145,9 @@
 
 TEST_F(RtcEventLogOutputFileDeathTest, WritingToInactiveFileForbidden) {
   RtcEventLogOutputFile output_file(output_file_name_, 2);
-  ASSERT_FALSE(output_file.Write(absl::string_view("abc")));
+  ASSERT_FALSE(output_file.Write("abc"));
   ASSERT_FALSE(output_file.IsActive());
-  EXPECT_DEATH(output_file.Write(absl::string_view("abc")), "");
+  EXPECT_DEATH(output_file.Write("abc"), "");
 }
 
 TEST_F(RtcEventLogOutputFileDeathTest, DisallowUnreasonableFileSizeLimits) {