- Add a SetPriority method to ThreadWrapper
- Remove 'priority' from CreateThread and related member variables from implementations
- Make supplying a name for threads, non-optional
BUG=
R=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44729004
Cr-Commit-Position: refs/heads/master@{#8810}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8810 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/webrtc/system_wrappers/source/thread_win.cc b/webrtc/system_wrappers/source/thread_win.cc
index 0c1a8f2..aa03b91 100644
--- a/webrtc/system_wrappers/source/thread_win.cc
+++ b/webrtc/system_wrappers/source/thread_win.cc
@@ -55,10 +55,9 @@
}
ThreadWindows::ThreadWindows(ThreadRunFunction func, void* obj,
- ThreadPriority prio, const char* thread_name)
+ const char* thread_name)
: run_function_(func),
obj_(obj),
- prio_(prio),
stop_(false),
thread_(NULL),
name_(thread_name ? thread_name : "webrtc") {
@@ -98,28 +97,6 @@
return false;
}
- if (prio_ != kNormalPriority) {
- int priority = THREAD_PRIORITY_NORMAL;
- switch (prio_) {
- case kLowPriority:
- priority = THREAD_PRIORITY_BELOW_NORMAL;
- break;
- case kHighPriority:
- priority = THREAD_PRIORITY_ABOVE_NORMAL;
- break;
- case kHighestPriority:
- priority = THREAD_PRIORITY_HIGHEST;
- break;
- case kRealtimePriority:
- priority = THREAD_PRIORITY_TIME_CRITICAL;
- break;
- default:
- break;
- }
-
- SetThreadPriority(thread_, priority);
- }
-
return true;
}
@@ -136,6 +113,11 @@
return true;
}
+bool ThreadWindows::SetPriority(ThreadPriority priority) {
+ DCHECK(main_thread_.CalledOnValidThread());
+ return thread_ && SetThreadPriority(thread_, priority);
+}
+
void ThreadWindows::Run() {
if (!name_.empty())
SetThreadName(static_cast<DWORD>(-1), name_.c_str());