commit af6b6e021ff43b1d96d6decf7e05868d1aff9f61
author honghaiz <honghaiz@webrtc.org> Mon Jul 11 15:09:26 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Jul 11 22:09:32 2016 +0000
tree ac28af0eb5c3d69351d242b351a71072dbde5d36
parent b4d31085b4534988ee37a4f2ed680a9ed1b34218

Prefix bool variable with "should".
This is to address a comment in a CL landed earlier.

BUG=

Review-Url: https://codereview.webrtc.org/2137223002
Cr-Commit-Position: refs/heads/master@{#13435}

webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
index 74b5c5d..be662888 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
@@ -33,8 +33,9 @@
     _iceBackupCandidatePairPingInterval;
 @synthesize keyType = _keyType;
 @synthesize iceCandidatePoolSize = _iceCandidatePoolSize;
-@synthesize pruneTurnPorts = _pruneTurnPorts;
-@synthesize presumeWritableWhenFullyRelayed = _presumeWritableWhenFullyRelayed;
+@synthesize shouldPruneTurnPorts = _shouldPruneTurnPorts;
+@synthesize shouldPresumeWritableWhenFullyRelayed =
+    _shouldPresumeWritableWhenFullyRelayed;
 
 - (instancetype)init {
   if (self = [super init]) {
@@ -61,8 +62,8 @@
         config.ice_backup_candidate_pair_ping_interval;
     _keyType = RTCEncryptionKeyTypeECDSA;
     _iceCandidatePoolSize = config.ice_candidate_pool_size;
-    _pruneTurnPorts = config.prune_turn_ports;
-    _presumeWritableWhenFullyRelayed =
+    _shouldPruneTurnPorts = config.prune_turn_ports;
+    _shouldPresumeWritableWhenFullyRelayed =
         config.presume_writable_when_fully_relayed;
   }
   return self;
@@ -83,8 +84,8 @@
       _iceConnectionReceivingTimeout,
       _iceBackupCandidatePairPingInterval,
       _iceCandidatePoolSize,
-      _pruneTurnPorts,
-      _presumeWritableWhenFullyRelayed];
+      _shouldPruneTurnPorts,
+      _shouldPresumeWritableWhenFullyRelayed];
 }
 
 #pragma mark - Private
@@ -128,9 +129,9 @@
     nativeConfig->certificates.push_back(certificate);
   }
   nativeConfig->ice_candidate_pool_size = _iceCandidatePoolSize;
-  nativeConfig->prune_turn_ports = _pruneTurnPorts;
+  nativeConfig->prune_turn_ports = _shouldPruneTurnPorts ? true : false;
   nativeConfig->presume_writable_when_fully_relayed =
-      _presumeWritableWhenFullyRelayed;
+      _shouldPresumeWritableWhenFullyRelayed ? true : false;
 
   return nativeConfig.release();
 }