Fix style violations in common_types.h and config.h
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.
The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.
BUG=163
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26089004
Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/webrtc/config.h b/webrtc/config.h
index 9f2a7a3..1777937 100644
--- a/webrtc/config.h
+++ b/webrtc/config.h
@@ -56,14 +56,8 @@
};
struct VideoStream {
- VideoStream()
- : width(0),
- height(0),
- max_framerate(-1),
- min_bitrate_bps(-1),
- target_bitrate_bps(-1),
- max_bitrate_bps(-1),
- max_qp(-1) {}
+ VideoStream();
+ ~VideoStream();
std::string ToString() const;
size_t width;
@@ -95,11 +89,8 @@
kScreenshare,
};
- VideoEncoderConfig()
- : content_type(kRealtimeVideo),
- encoder_specific_settings(NULL),
- min_transmit_bitrate_bps(0) {}
-
+ VideoEncoderConfig();
+ ~VideoEncoderConfig();
std::string ToString() const;
std::vector<VideoStream> streams;