commit aa8b67da9d205d21c6718cd6e98d445bd3645f86
author Oskar Sundbom <ossu@webrtc.org> Fri Nov 17 14:34:48 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Mon Nov 20 10:19:30 2017 +0000
tree 9df355adca5df4aca717c17c72ff9fec7ea3f9d5
parent 28dfeb7f249d4bbbb319ffd3f72a3abd00a7885d

Optional: Use nullopt and implicit construction in /modules/audio_processing

Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.

This CL was uploaded by git cl split.

R=henrik.lundin@webrtc.org

Bug: None
Change-Id: I733a83f702fe11884d229a1713cfac952727bde8
Reviewed-on: https://webrtc-review.googlesource.com/23601
Commit-Queue: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20786}

modules/audio_processing/beamformer/array_util.cc

diff --git a/modules/audio_processing/beamformer/array_util.cc b/modules/audio_processing/beamformer/array_util.cc
index f5862bb..e853559 100644
--- a/modules/audio_processing/beamformer/array_util.cc
+++ b/modules/audio_processing/beamformer/array_util.cc
@@ -65,10 +65,10 @@
     const Point pair_direction =
         PairDirection(array_geometry[i - 1], array_geometry[i]);
     if (!AreParallel(first_pair_direction, pair_direction)) {
-      return rtc::Optional<Point>();
+      return rtc::nullopt;
     }
   }
-  return rtc::Optional<Point>(first_pair_direction);
+  return first_pair_direction;
 }
 
 rtc::Optional<Point> GetNormalIfPlanar(
@@ -86,30 +86,30 @@
     }
   }
   if (is_linear) {
-    return rtc::Optional<Point>();
+    return rtc::nullopt;
   }
   const Point normal_direction =
       CrossProduct(first_pair_direction, pair_direction);
   for (; i < array_geometry.size(); ++i) {
     pair_direction = PairDirection(array_geometry[i - 1], array_geometry[i]);
     if (!ArePerpendicular(normal_direction, pair_direction)) {
-      return rtc::Optional<Point>();
+      return rtc::nullopt;
     }
   }
-  return rtc::Optional<Point>(normal_direction);
+  return normal_direction;
 }
 
 rtc::Optional<Point> GetArrayNormalIfExists(
     const std::vector<Point>& array_geometry) {
   const rtc::Optional<Point> direction = GetDirectionIfLinear(array_geometry);
   if (direction) {
-    return rtc::Optional<Point>(Point(direction->y(), -direction->x(), 0.f));
+    return Point(direction->y(), -direction->x(), 0.f);
   }
   const rtc::Optional<Point> normal = GetNormalIfPlanar(array_geometry);
   if (normal && normal->z() < kMaxDotProduct) {
     return normal;
   }
-  return rtc::Optional<Point>();
+  return rtc::nullopt;
 }
 
 Point AzimuthToPoint(float azimuth) {