RefCounter::DecRef: Remove obsolete TODO and update comment
Bug: webrtc:10198
Change-Id: Icbcb849bdc789d9e3bb7ea6a902475a8263980bf
Reviewed-on: https://webrtc-review.googlesource.com/c/117300
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26242}diff --git a/rtc_base/ref_counter.h b/rtc_base/ref_counter.h
index 9b4d5ef..600dda8 100644
--- a/rtc_base/ref_counter.h
+++ b/rtc_base/ref_counter.h
@@ -23,9 +23,11 @@
void IncRef() { rtc::AtomicOps::Increment(&ref_count_); }
- // TODO(nisse): Switch return type to RefCountReleaseStatus?
- // Returns true if this was the last reference, and the resource protected by
- // the reference counter can be deleted.
+ // Returns kDroppedLastRef if this call dropped the last reference; the caller
+ // should therefore free the resource protected by the reference counter.
+ // Otherwise, returns kOtherRefsRemained (note that in case of multithreading,
+ // some other caller may have dropped the last reference by the time this call
+ // returns; all we know is that we didn't do it).
rtc::RefCountReleaseStatus DecRef() {
return (rtc::AtomicOps::Decrement(&ref_count_) == 0)
? rtc::RefCountReleaseStatus::kDroppedLastRef