commit a8565425bc6b1d3d7b5a0b0e0a49bc4e57c64f21
author mflodman <mflodman@webrtc.org> Mon Dec 07 01:09:52 2015 -0800
committer Commit bot <commit-bot@chromium.org> Mon Dec 07 09:10:01 2015 +0000
tree b3240d2624c3f1e4848ad9e57b383c78d5eabbf4
parent 2512f443975c1dc71391bf6cadf587e0ced3344a

Initial VideoProcessing refactoring.

This CL is the first in a series of CLs to refactor
VideoProcessing(Module) to follow Google C++ style guide and make the
code more readable.

This CL removed inheritance from Module, renames variables and makes
VideoProcessingImpl::PreprocessFrame return a frame pointer if there
is a frame to send, nullptr otherwise. The affected CLs also passes git
cl lint.

BUG=webrtc:5259

Review URL: https://codereview.webrtc.org/1482913003

Cr-Commit-Position: refs/heads/master@{#10907}

webrtc/modules/video_processing/frame_preprocessor.h

diff --git a/webrtc/modules/video_processing/frame_preprocessor.h b/webrtc/modules/video_processing/frame_preprocessor.h
index 2759260..8e6bb9b 100644
--- a/webrtc/modules/video_processing/frame_preprocessor.h
+++ b/webrtc/modules/video_processing/frame_preprocessor.h
@@ -8,22 +8,23 @@
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-/*
- * frame_preprocessor.h
- */
 #ifndef WEBRTC_MODULES_VIDEO_PROCESSING_FRAME_PREPROCESSOR_H_
 #define WEBRTC_MODULES_VIDEO_PROCESSING_FRAME_PREPROCESSOR_H_
 
+#include "webrtc/base/scoped_ptr.h"
 #include "webrtc/modules/video_processing/include/video_processing.h"
 #include "webrtc/modules/video_processing/content_analysis.h"
 #include "webrtc/modules/video_processing/spatial_resampler.h"
 #include "webrtc/modules/video_processing/video_decimator.h"
-#include "webrtc/modules/video_processing/video_denoiser.h"
 #include "webrtc/typedefs.h"
 #include "webrtc/video_frame.h"
 
 namespace webrtc {
 
+class VideoDenoiser;
+
+// All pointers/members in this class are assumed to be protected by the class
+// owner.
 class VPMFramePreprocessor {
  public:
   VPMFramePreprocessor();
@@ -52,14 +53,14 @@
   int32_t updateIncomingFrameSize(uint32_t width, uint32_t height);
 
   // Set decimated values: frame rate/dimension.
-  uint32_t Decimatedframe_rate();
-  uint32_t DecimatedWidth() const;
-  uint32_t DecimatedHeight() const;
+  uint32_t GetDecimatedFrameRate();
+  uint32_t GetDecimatedWidth() const;
+  uint32_t GetDecimatedHeight() const;
 
   // Preprocess output:
-  int32_t PreprocessFrame(const VideoFrame& frame,
-                          VideoFrame** processed_frame);
-  VideoContentMetrics* ContentMetrics() const;
+  void EnableDenosing(bool enable);
+  const VideoFrame* PreprocessFrame(const VideoFrame& frame);
+  VideoContentMetrics* GetContentMetrics() const;
 
  private:
   // The content does not change so much every frame, so to reduce complexity
@@ -72,13 +73,11 @@
   VPMSpatialResampler* spatial_resampler_;
   VPMContentAnalysis* ca_;
   VPMVideoDecimator* vd_;
-  VideoDenoiser* denoiser_;
+  rtc::scoped_ptr<VideoDenoiser> denoiser_;
   bool enable_ca_;
-  bool enable_denoising_;
-  int frame_cnt_;
-
+  uint32_t frame_cnt_;
 };
 
 }  // namespace webrtc
 
-#endif // WEBRTC_MODULES_VIDEO_PROCESSING_FRAME_PREPROCESSOR_H_
+#endif  // WEBRTC_MODULES_VIDEO_PROCESSING_FRAME_PREPROCESSOR_H_