commit a5f267d5aced6e76404fc36f0bf26be468b69a14
author Sylvain Defresne <sdefresne@chromium.org> Fri Jul 01 16:24:47 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 04 09:01:52 2022 +0000
tree 5674f6cf31b496452980fb77b108f021fc6fc22f
parent 67d23043f3e3c3589dfe884f6ce4ee74b9674cba

[ios] Remove the support for bitcode

According to Xcode 14 documentation [1]:

  > Xcode no longer builds bitcode by default and generates a warning
  > message if a project explicitly enables bitcode: “Building with
  > bitcode is deprecated. Please update your project and/or target
  > settings to disable bitcode.” The capability to build with bitcode
  > will be removed in a future Xcode release. IPAs that contain bitcode
  > will have the bitcode stripped before being submitted to the App
  > Store. Debug symbols for past bitcode submissions remain available
  > for download. (86118779)

[1]: https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes

Bug: webrtc:14237
Change-Id: I39fb618409e1978f8e7b42aa71208e00ed69d85f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267407
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37415}

tools_webrtc/ios/build_ios_libs.py

diff --git a/tools_webrtc/ios/build_ios_libs.py b/tools_webrtc/ios/build_ios_libs.py
index 9a4c3e3..01a95b0 100755
--- a/tools_webrtc/ios/build_ios_libs.py
+++ b/tools_webrtc/ios/build_ios_libs.py
@@ -87,11 +87,6 @@
       type=int,
       default=0,
       help='Specifies a revision number to embed if building the framework.')
-  parser.add_argument('-e',
-                      '--bitcode',
-                      action='store_true',
-                      default=False,
-                      help='Compile with bitcode.')
   parser.add_argument('--verbose',
                       action='store_true',
                       default=False,
@@ -154,7 +149,7 @@
 
 def BuildWebRTC(output_dir, target_environment, target_arch, flavor,
                 gn_target_name, ios_deployment_target, libvpx_build_vp9,
-                use_bitcode, use_goma, extra_gn_args):
+                use_goma, extra_gn_args):
   gn_args = [
       'target_os="ios"',
       'ios_enable_code_signing=false',
@@ -179,8 +174,7 @@
   gn_args.append('rtc_libvpx_build_vp9=' +
                  ('true' if libvpx_build_vp9 else 'false'))
 
-  gn_args.append('enable_ios_bitcode=' + ('true' if use_bitcode else 'false'))
-  gn_args.append('use_lld=' + ('false' if use_bitcode else 'true'))
+  gn_args.append('use_lld=true')
   gn_args.append('use_goma=' + ('true' if use_goma else 'false'))
   gn_args.append('rtc_enable_objc_symbol_export=true')
 
@@ -228,8 +222,7 @@
     return 0
 
   gn_target_name = 'framework_objc'
-  if not args.bitcode:
-    gn_args.append('enable_dsyms=true')
+  gn_args.append('enable_dsyms=true')
   gn_args.append('enable_stripping=true')
 
   # Build all architectures.
@@ -244,7 +237,7 @@
       lib_paths.append(lib_path)
       BuildWebRTC(lib_path, environment, arch, args.build_config,
                   gn_target_name, IOS_DEPLOYMENT_TARGET[environment],
-                  LIBVPX_BUILD_VP9, args.bitcode, args.use_goma, gn_args)
+                  LIBVPX_BUILD_VP9, args.use_goma, gn_args)
     all_lib_paths.extend(lib_paths)
 
     # Combine the slices.