commit a5f043f9cd201fff209e96415bebcb8445ba0176
author nisse <nisse@webrtc.org> Mon Sep 18 07:58:59 2017 -0700
committer Commit Bot <commit-bot@chromium.org> Mon Sep 18 14:58:59 2017 +0000
tree 0b7d2d8d13f3f9057854734667bb0fa287c3128e
parent dd3abbb53250072dc5baac0391ebea135be6fa53

Change ForwardErrorCorrection class to accept one received packet at a time.

BUG=None

Review-Url: https://codereview.webrtc.org/3012243002
Cr-Commit-Position: refs/heads/master@{#19893}

modules/rtp_rtcp/source/ulpfec_receiver_impl.cc

diff --git a/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc b/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
index a35393d..4292f3c 100644
--- a/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
+++ b/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc
@@ -216,23 +216,22 @@
   return 0;
 }
 
+// TODO(nisse): Drop always-zero return value.
 int32_t UlpfecReceiverImpl::ProcessReceivedFec() {
   crit_sect_.Enter();
-  if (!received_packets_.empty()) {
+  for (const auto& received_packet : received_packets_) {
     // Send received media packet to VCM.
-    if (!received_packets_.front()->is_fec) {
-      ForwardErrorCorrection::Packet* packet = received_packets_.front()->pkt;
+    if (!received_packet->is_fec) {
+      ForwardErrorCorrection::Packet* packet = received_packet->pkt;
       crit_sect_.Leave();
       recovered_packet_callback_->OnRecoveredPacket(packet->data,
                                                     packet->length);
       crit_sect_.Enter();
     }
-    if (fec_->DecodeFec(&received_packets_, &recovered_packets_) != 0) {
-      crit_sect_.Leave();
-      return -1;
-    }
-    RTC_DCHECK(received_packets_.empty());
+    fec_->DecodeFec(*received_packet, &recovered_packets_);
   }
+  received_packets_.clear();
+
   // Send any recovered media packets to VCM.
   for (const auto& recovered_packet : recovered_packets_) {
     if (recovered_packet->returned) {