commit 9f00f0e533fe2f9319517dfb225a194cac01eaab
author Bjorn Terelius <terelius@webrtc.org> Fri Aug 30 09:39:31 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Aug 30 08:23:37 2019 +0000
tree 414a064dd82776e141c53e0b32bc843d64a551e4
parent f3a197e55323aee974a932c52dd19fa88e5d4e38

Add support for unsigned parameters in FieldTrialParser

Bug: webrtc:10932
Change-Id: I3f56244a6be532065e4096cf1a289e27a032bc44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150886
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29018}

rtc_base/experiments/struct_parameters_parser_unittest.cc

diff --git a/rtc_base/experiments/struct_parameters_parser_unittest.cc b/rtc_base/experiments/struct_parameters_parser_unittest.cc
index 69103bd..71b117f 100644
--- a/rtc_base/experiments/struct_parameters_parser_unittest.cc
+++ b/rtc_base/experiments/struct_parameters_parser_unittest.cc
@@ -16,6 +16,7 @@
   bool enabled = false;
   double factor = 0.5;
   int retries = 5;
+  unsigned size = 3;
   bool ping = 0;
   absl::optional<TimeDelta> duration;
   absl::optional<TimeDelta> latency = TimeDelta::ms(100);
@@ -27,6 +28,7 @@
   return StructParametersParser::Create("e", &enabled,   //
                                         "f", &factor,    //
                                         "r", &retries,   //
+                                        "s", &size,      //
                                         "p", &ping,      //
                                         "d", &duration,  //
                                         "l", &latency);
@@ -35,10 +37,11 @@
 
 TEST(StructParametersParserTest, ParsesValidParameters) {
   DummyConfig exp;
-  exp.Parser()->Parse("e:1,f:-1.7,r:2,p:1,d:8,l:,");
+  exp.Parser()->Parse("e:1,f:-1.7,r:2,s:7,p:1,d:8,l:,");
   EXPECT_TRUE(exp.enabled);
   EXPECT_EQ(exp.factor, -1.7);
   EXPECT_EQ(exp.retries, 2);
+  EXPECT_EQ(exp.size, 7u);
   EXPECT_EQ(exp.ping, true);
   EXPECT_EQ(exp.duration.value().ms(), 8);
   EXPECT_FALSE(exp.latency);
@@ -50,6 +53,7 @@
   EXPECT_FALSE(exp.enabled);
   EXPECT_EQ(exp.factor, 0.5);
   EXPECT_EQ(exp.retries, 5);
+  EXPECT_EQ(exp.size, 3u);
   EXPECT_EQ(exp.ping, false);
 }
 
@@ -57,7 +61,7 @@
   DummyConfig exp;
   auto encoded = exp.Parser()->Encode();
   // All parameters are encoded.
-  EXPECT_EQ(encoded, "e:false,f:0.5,r:5,p:false,d:,l:100 ms");
+  EXPECT_EQ(encoded, "e:false,f:0.5,r:5,s:3,p:false,d:,l:100 ms");
 }
 
 }  // namespace webrtc