commit 9aef5dc2ab2660722d6f4e3fa3d59be9ffb47fdc
author Artem Titov <titovartem@webrtc.org> Tue May 22 16:44:23 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Tue May 22 15:26:38 2018 +0000
tree 0d06cb79e536b95e60f86d4bc174297ddd19cc53
parent 43c707ada5d399e33a7ff28dcd08aaeb5e41d764

Disable owners check in PRESUBMIT.py for chromium owned 3pp deps.

Bug: webrtc:8366
Change-Id: I18a7117d13dfacc2b305c304037a0d3b55b6df3b
Reviewed-on: https://webrtc-review.googlesource.com/78284
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23352}

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 37948db..7575948 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -852,9 +852,23 @@
 
 def CheckChangeOnCommit(input_api, output_api):
   results = []
+
+  # We have to skip OWNERS check for chromium-specific third_party deps.
+  chromium_deps_file = input_api.os_path.join(
+      input_api.PresubmitLocalPath(),
+      'THIRD_PARTY_CHROMIUM_DEPS.json')
+  with open(chromium_deps_file, 'rb') as f:
+    chromium_deps = json.load(f).get('dependencies', [])
+  deps_blacklist = []
+  for dep in chromium_deps:
+    deps_blacklist.append(r'^third_party[\\\/]%s[\\\/].+' % dep)
+  deps_filter = lambda x: input_api.FilterSourceFile(
+      x, black_list=deps_blacklist)
+
   results.extend(CommonChecks(input_api, output_api))
   results.extend(VerifyNativeApiHeadersListIsValid(input_api, output_api))
-  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
+  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api,
+      source_file_filter=deps_filter))
   results.extend(input_api.canned_checks.CheckChangeWasUploaded(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(