commit 95c56eebe0a2b31ad5752138d15b431124e17d36
author Anders Carlsson <andersc@webrtc.org> Thu Sep 06 15:48:17 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Sep 06 14:13:11 2018 +0000
tree 35d321335f746a66b494db80f50180c68889692e
parent 366a50c4ef1111a32753302b47a5504fbc3212f5

Fix paths for macOS framework’s copy actions.

Using the mac framework bundle's path should be more correct than the
hardcoded version used previously.

Bug: webrtc:9627
Change-Id: I706c7961f21ba921503ed68b6e79ea0838e664d5
Reviewed-on: https://webrtc-review.googlesource.com/98620
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Anders Carlsson <andersc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24606}

webrtc.gni

diff --git a/webrtc.gni b/webrtc.gni
index 41397f3..8970f55 100644
--- a/webrtc.gni
+++ b/webrtc.gni
@@ -698,8 +698,8 @@
 if (is_mac) {
   template("mac_framework_bundle_with_umbrella_header") {
     forward_variables_from(invoker, [ "output_name" ])
-    umbrella_header_path =
-        "$target_gen_dir/$output_name.framework/Headers/$output_name.h"
+    this_target_name = target_name
+    umbrella_header_path = "$target_gen_dir/umbrella_header/$output_name.h"
 
     mac_framework_bundle(target_name) {
       forward_variables_from(invoker, "*", [])
@@ -714,20 +714,21 @@
       ]
 
       deps += [
-        ":copy_framework_headers_$target_name",
-        ":copy_umbrella_header_$target_name",
+        ":copy_framework_headers_$this_target_name",
+        ":copy_umbrella_header_$this_target_name",
+        ":umbrella_header_$this_target_name",
       ]
     }
 
-    copy("copy_framework_headers_$target_name") {
+    bundle_data("copy_framework_headers_$this_target_name") {
       forward_variables_from(invoker, [ "sources" ])
 
       outputs = [
-        "$root_out_dir/$output_name.framework/Headers/{{source_file_part}}",
+        "{{bundle_contents_dir}}/Headers/{{source_file_part}}",
       ]
     }
 
-    action("umbrella_header_$target_name") {
+    action("umbrella_header_$this_target_name") {
       forward_variables_from(invoker, [ "sources" ])
 
       script = "//tools_webrtc/ios/generate_umbrella_header.py"
@@ -742,16 +743,16 @@
              ] + sources
     }
 
-    copy("copy_umbrella_header_$target_name") {
+    bundle_data("copy_umbrella_header_$this_target_name") {
       sources = [
         umbrella_header_path,
       ]
       outputs = [
-        "$root_out_dir/$output_name.framework/Headers/$output_name.h",
+        "{{bundle_contents_dir}}/Headers/$output_name.h",
       ]
 
       deps = [
-        ":umbrella_header_$target_name",
+        ":umbrella_header_$this_target_name",
       ]
     }
   }