commit 94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc
author kjellander <kjellander@webrtc.org> Thu Mar 09 06:09:33 2017 -0800
committer Commit bot <commit-bot@chromium.org> Thu Mar 09 14:09:33 2017 +0000
tree cc2b6fa5354ec90f7f7e9dea19b50be4d7dee677
parent 09f3e3e7b46c6dd324ff80bda1a3a0867f3a1317

Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )

Reason for revert:
Fails video quality tests in Chrome:  http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
I should have looked more closer at those :(

Original issue's description:
> PyLint fixes for tools-webrtc and webrtc/tools
>
> Fix a lot of errors before bringing in the new config in
> https://codereview.webrtc.org/2737963003/
>
> BUG=webrtc:7303
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2736233003
> Cr-Commit-Position: refs/heads/master@{#17137}
> Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303

Review-Url: https://codereview.webrtc.org/2737233003
Cr-Commit-Position: refs/heads/master@{#17142}

tools-webrtc/get_landmines.py

diff --git a/tools-webrtc/get_landmines.py b/tools-webrtc/get_landmines.py
index 95ee536..dd0c9b0 100755
--- a/tools-webrtc/get_landmines.py
+++ b/tools-webrtc/get_landmines.py
@@ -15,16 +15,19 @@
 import os
 import sys
 
-SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
-CHECKOUT_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))
-sys.path.insert(0, os.path.join(CHECKOUT_ROOT, 'build'))
+script_dir = os.path.dirname(os.path.realpath(__file__))
+checkout_root = os.path.abspath(os.path.join(script_dir, os.pardir))
+sys.path.insert(0, os.path.join(checkout_root, 'build'))
 import landmine_utils
 
 
-platform = landmine_utils.platform  # pylint: disable=invalid-name
+distributor = landmine_utils.distributor
+gyp_defines = landmine_utils.gyp_defines
+gyp_msvs_version = landmine_utils.gyp_msvs_version
+platform = landmine_utils.platform
 
 
-def print_landmines():  # pylint: disable=invalid-name
+def print_landmines():
   """
   ALL LANDMINES ARE EMITTED FROM HERE.
   """
@@ -51,7 +54,7 @@
     # is no longer the case.
     print 'Clobber due to iOS compile errors (crbug.com/694721)'
     print 'Clobber to unblock https://codereview.webrtc.org/2709573003'
-    print 'Clobber to fix after https://codereview.webrtc.org/2709573003'
+    print 'Clobber to fix https://codereview.webrtc.org/2709573003 after landing'
 
 
 def main():