commit 94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc
author kjellander <kjellander@webrtc.org> Thu Mar 09 06:09:33 2017 -0800
committer Commit bot <commit-bot@chromium.org> Thu Mar 09 14:09:33 2017 +0000
tree cc2b6fa5354ec90f7f7e9dea19b50be4d7dee677
parent 09f3e3e7b46c6dd324ff80bda1a3a0867f3a1317

Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )

Reason for revert:
Fails video quality tests in Chrome:  http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
I should have looked more closer at those :(

Original issue's description:
> PyLint fixes for tools-webrtc and webrtc/tools
>
> Fix a lot of errors before bringing in the new config in
> https://codereview.webrtc.org/2737963003/
>
> BUG=webrtc:7303
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2736233003
> Cr-Commit-Position: refs/heads/master@{#17137}
> Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303

Review-Url: https://codereview.webrtc.org/2737233003
Cr-Commit-Position: refs/heads/master@{#17142}

tools-webrtc/check_package_boundaries_test.py

diff --git a/tools-webrtc/check_package_boundaries_test.py b/tools-webrtc/check_package_boundaries_test.py
index 1487a23..c59c485 100755
--- a/tools-webrtc/check_package_boundaries_test.py
+++ b/tools-webrtc/check_package_boundaries_test.py
@@ -30,7 +30,7 @@
     self.messages = []
     self.test_dir = test_dir
 
-  def Log(self, build_file_path, line_number, target_name, source_file,
+  def log(self, build_file_path, line_number, target_name, source_file,
           subpackage):
     build_file_path = os.path.relpath(build_file_path, self.test_dir)
     build_file_path = build_file_path.replace(os.path.sep, '/')
@@ -48,19 +48,19 @@
     expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl'))
     self.assertListEqual(sorted(expected_messages), sorted(logger.messages))
 
-  def testNoErrors(self):
+  def test_no_errors(self):
     self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors'))
 
-  def testMultipleErrorsSingleTarget(self):
+  def test_multiple_errors_single_target(self):
     self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target'))
 
-  def testMultipleErrorsMultipleTargets(self):
+  def test_multiple_errors_multiple_targets(self):
     self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets'))
 
-  def testCommonPrefix(self):
+  def test_common_prefix(self):
     self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix'))
 
-  def testAllBuildFiles(self):
+  def test_all_build_files(self):
     self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True)