commit 92e89d7f77bf637538abb1f9f898de87d3c2edaa
author Evan Shrubsole <eshr@webrtc.org> Tue Mar 22 10:55:15 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 22 15:15:13 2022 +0000
tree e7e722b5d1340f5fffa0937ba3a9330102f904bc
parent 6ceb81f62b5216f4378601483b423ec9de1a0355

[cleanup] Return struct from VCMTiming::GetTimings

Cleans callers having to initialize TimeDeltas.

Change-Id: Ib00a59bedf05fb82c9fde1d9fdd1e341e2132cb8
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256360
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36292}

modules/video_coding/receiver_unittest.cc

diff --git a/modules/video_coding/receiver_unittest.cc b/modules/video_coding/receiver_unittest.cc
index 73c88a5..e38f9c5 100644
--- a/modules/video_coding/receiver_unittest.cc
+++ b/modules/video_coding/receiver_unittest.cc
@@ -448,11 +448,9 @@
   int64_t arrive_timestamps[kNumFrames];
   int64_t render_timestamps[kNumFrames];
 
-  TimeDelta render_delay_ms = TimeDelta::Zero();
-  TimeDelta max_decode_ms = TimeDelta::Zero();
-  TimeDelta dummy = TimeDelta::Zero();
-  timing_.GetTimings(&max_decode_ms, &dummy, &dummy, &dummy, &dummy,
-                     &render_delay_ms);
+  auto timings = timing_.GetTimings();
+  TimeDelta render_delay = timings.render_delay;
+  TimeDelta max_decode = timings.max_decode_duration;
 
   // Construct test samples.
   // render_timestamps are the timestamps stored in the Frame;
@@ -479,9 +477,8 @@
         receiver_.FrameForDecoding(kMaxWaitTime, prefer_late_decoding);
     int64_t end_time = clock_.TimeInMilliseconds();
     if (frame) {
-      EXPECT_EQ(
-          frame->RenderTimeMs() - max_decode_ms.ms() - render_delay_ms.ms(),
-          end_time);
+      EXPECT_EQ(frame->RenderTimeMs() - max_decode.ms() - render_delay.ms(),
+                end_time);
       receiver_.ReleaseFrame(frame);
       ++num_frames_return;
     } else {