commit 909338b0277af58dc38ea14a828e20e4e392a07a
author Max Morin <maxmorin@webrtc.org> Mon May 07 06:09:37 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Mon May 07 08:02:34 2018 +0000
tree 14952d4bb82c8fd3df316ca2df0d082a4bf001f8
parent b044d3a28f077af941c5d49a5fa90b7b7a408749

Revert "Implement RtpParameters.transaction_id for PC RtpSenderInterface"

This reverts commit 5faf36ef3c582350fba5ef97a3549e440d81a283.

Reason for revert: fast/peerconnection/RTCRtpSender-setParameters.html
 failing in webrtc roll, probably this CL? https://chromium-review.googlesource.com/c/chromium/src/+/1045889.

Original change's description:
> Implement RtpParameters.transaction_id for PC RtpSenderInterface
> 
> The transaction_id field should be refreshed for every getParameters()
> call and checked at each setParameters() call.
> This also checks that getParameters() was ever called to return a proper
> error code.
> 
> Bug: webrtc:7580
> Change-Id: I6c6fe289542e486fc422cdc61577982b0529d4c1
> Reviewed-on: https://webrtc-review.googlesource.com/70820
> Commit-Queue: Florent Castelli <orphis@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Reviewed-by: Steve Anton <steveanton@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23120}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org,sakal@webrtc.org,kthelgason@webrtc.org,orphis@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:7580
Change-Id: I86da108227f8fc8d235bb2e9559377c800595b8c
Reviewed-on: https://webrtc-review.googlesource.com/74740
Reviewed-by: Max Morin <maxmorin@webrtc.org>
Commit-Queue: Max Morin <maxmorin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23134}

sdk/android/api/org/webrtc/RtpParameters.java

diff --git a/sdk/android/api/org/webrtc/RtpParameters.java b/sdk/android/api/org/webrtc/RtpParameters.java
index f2227ae..634f3b3 100644
--- a/sdk/android/api/org/webrtc/RtpParameters.java
+++ b/sdk/android/api/org/webrtc/RtpParameters.java
@@ -109,24 +109,21 @@
     }
   }
 
-  public final String transactionId;
-
   public final List<Encoding> encodings;
   // Codec parameters can't currently be changed between getParameters and
   // setParameters. Though in the future it will be possible to reorder them or
   // remove them.
   public final List<Codec> codecs;
 
-  @CalledByNative
-  RtpParameters(String transactionId, List<Encoding> encodings, List<Codec> codecs) {
-    this.transactionId = transactionId;
-    this.encodings = encodings;
-    this.codecs = codecs;
+  public RtpParameters() {
+    this.encodings = new ArrayList<>();
+    this.codecs = new ArrayList<>();
   }
 
   @CalledByNative
-  String getTransactionId() {
-    return transactionId;
+  RtpParameters(List<Encoding> encodings, List<Codec> codecs) {
+    this.encodings = encodings;
+    this.codecs = codecs;
   }
 
   @CalledByNative