Make lint errors fatal in presubmit and fix files in whitelisted paths
BUG=webrtc:5149
Review-Url: https://codereview.webrtc.org/2762963002
Cr-Commit-Position: refs/heads/master@{#17323}
diff --git a/webrtc/api/rtcerror.h b/webrtc/api/rtcerror.h
index 2ba7837..5cb1232 100644
--- a/webrtc/api/rtcerror.h
+++ b/webrtc/api/rtcerror.h
@@ -203,7 +203,7 @@
// is marked 'explicit' to try to catch cases like 'return {};', where people
// think RTCErrorOr<std::vector<int>> will be initialized with an empty
// vector, instead of a RTCErrorType::INTERNAL_ERROR error.
- explicit RTCErrorOr() : error_(RTCErrorType::INTERNAL_ERROR) {}
+ RTCErrorOr() : error_(RTCErrorType::INTERNAL_ERROR) {}
// Constructs a new RTCErrorOr with the given non-ok error. After calling
// this constructor, calls to value() will DCHECK-fail.
@@ -213,7 +213,7 @@
// RTCError(...)' when the return type is RTCErrorOr<T>.
//
// REQUIRES: !error.ok(). This requirement is DCHECKed.
- RTCErrorOr(RTCError&& error) : error_(std::move(error)) {
+ RTCErrorOr(RTCError&& error) : error_(std::move(error)) { // NOLINT
RTC_DCHECK(!error.ok());
}
@@ -224,7 +224,7 @@
// NOTE: Not explicit - we want to use RTCErrorOr<T> as a return type
// so it is convenient and sensible to be able to do 'return T()'
// when the return type is RTCErrorOr<T>.
- RTCErrorOr(T&& value) : value_(std::move(value)) {}
+ RTCErrorOr(T&& value) : value_(std::move(value)) {} // NOLINT
// Delete the copy constructor and assignment operator; there aren't any use
// cases where you should need to copy an RTCErrorOr, as opposed to moving
@@ -248,7 +248,7 @@
// Conversion constructor and assignment operator; T must be copy or move
// constructible from U.
template <typename U>
- RTCErrorOr(RTCErrorOr<U> other)
+ RTCErrorOr(RTCErrorOr<U> other) // NOLINT
: error_(std::move(other.error_)), value_(std::move(other.value_)) {}
template <typename U>
RTCErrorOr& operator=(RTCErrorOr<U> other) {