Reformat python files checked by pylint (part 1/2).
After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.
This CL moves all these files one step closer to what the linter
wants.
Autogenerated with:
# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full
This is part 1 out of 2. The second part will fix function names and
will not be automated.
[1] - https://webrtc-review.googlesource.com/c/src/+/186664
No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
diff --git a/tools_webrtc/download_tools.py b/tools_webrtc/download_tools.py
index 9554c8c..62602de 100755
--- a/tools_webrtc/download_tools.py
+++ b/tools_webrtc/download_tools.py
@@ -6,7 +6,6 @@
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
-
"""Downloads precompiled tools.
These are checked into the repository as SHA-1 hashes (see *.sha1 files in
@@ -17,12 +16,10 @@
import os
import sys
-
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
SRC_DIR = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))
sys.path.append(os.path.join(SRC_DIR, 'build'))
-
import find_depot_tools
find_depot_tools.add_depot_tools_to_path()
import gclient_utils
@@ -30,32 +27,34 @@
def main(directories):
- if not directories:
- directories = [SCRIPT_DIR]
+ if not directories:
+ directories = [SCRIPT_DIR]
- for path in directories:
- cmd = [
- sys.executable,
- os.path.join(find_depot_tools.DEPOT_TOOLS_PATH,
- 'download_from_google_storage.py'),
- '--directory',
- '--num_threads=10',
- '--bucket', 'chrome-webrtc-resources',
- '--auto_platform',
- '--recursive',
- path,
- ]
- print 'Downloading precompiled tools...'
+ for path in directories:
+ cmd = [
+ sys.executable,
+ os.path.join(find_depot_tools.DEPOT_TOOLS_PATH,
+ 'download_from_google_storage.py'),
+ '--directory',
+ '--num_threads=10',
+ '--bucket',
+ 'chrome-webrtc-resources',
+ '--auto_platform',
+ '--recursive',
+ path,
+ ]
+ print 'Downloading precompiled tools...'
- # Perform download similar to how gclient hooks execute.
- try:
- gclient_utils.CheckCallAndFilter(
- cmd, cwd=SRC_DIR, always_show_header=True)
- except (gclient_utils.Error, subprocess2.CalledProcessError) as e:
- print 'Error: %s' % str(e)
- return 2
- return 0
+ # Perform download similar to how gclient hooks execute.
+ try:
+ gclient_utils.CheckCallAndFilter(cmd,
+ cwd=SRC_DIR,
+ always_show_header=True)
+ except (gclient_utils.Error, subprocess2.CalledProcessError) as e:
+ print 'Error: %s' % str(e)
+ return 2
+ return 0
if __name__ == '__main__':
- sys.exit(main(sys.argv[1:]))
+ sys.exit(main(sys.argv[1:]))