Reformat python files checked by pylint (part 1/2).
After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.
This CL moves all these files one step closer to what the linter
wants.
Autogenerated with:
# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full
This is part 1 out of 2. The second part will fix function names and
will not be automated.
[1] - https://webrtc-review.googlesource.com/c/src/+/186664
No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
diff --git a/rtc_tools/metrics_plotter.py b/rtc_tools/metrics_plotter.py
index 37a9d63..3b746ad 100644
--- a/rtc_tools/metrics_plotter.py
+++ b/rtc_tools/metrics_plotter.py
@@ -39,52 +39,59 @@
def main():
- parser = argparse.ArgumentParser(
- description='Plots metrics exported from WebRTC perf tests')
- parser.add_argument('-m', '--metrics', type=str, nargs='*',
- help='Metrics to plot. If nothing specified then will plot all available')
- args = parser.parse_args()
+ parser = argparse.ArgumentParser(
+ description='Plots metrics exported from WebRTC perf tests')
+ parser.add_argument(
+ '-m',
+ '--metrics',
+ type=str,
+ nargs='*',
+ help=
+ 'Metrics to plot. If nothing specified then will plot all available')
+ args = parser.parse_args()
- metrics_to_plot = set()
- if args.metrics:
- for metric in args.metrics:
- metrics_to_plot.add(metric)
+ metrics_to_plot = set()
+ if args.metrics:
+ for metric in args.metrics:
+ metrics_to_plot.add(metric)
- metrics = []
- for line in fileinput.input('-'):
- line = line.strip()
- if line.startswith(LINE_PREFIX):
- line = line.replace(LINE_PREFIX, '')
- metrics.append(json.loads(line))
- else:
- print line
+ metrics = []
+ for line in fileinput.input('-'):
+ line = line.strip()
+ if line.startswith(LINE_PREFIX):
+ line = line.replace(LINE_PREFIX, '')
+ metrics.append(json.loads(line))
+ else:
+ print line
- for metric in metrics:
- if len(metrics_to_plot) > 0 and metric[GRAPH_NAME] not in metrics_to_plot:
- continue
+ for metric in metrics:
+ if len(metrics_to_plot
+ ) > 0 and metric[GRAPH_NAME] not in metrics_to_plot:
+ continue
- figure = plt.figure()
- figure.canvas.set_window_title(metric[TRACE_NAME])
+ figure = plt.figure()
+ figure.canvas.set_window_title(metric[TRACE_NAME])
- x_values = []
- y_values = []
- start_x = None
- samples = metric['samples']
- samples.sort(key=lambda x: x['time'])
- for sample in samples:
- if start_x is None:
- start_x = sample['time']
- # Time is us, we want to show it in seconds.
- x_values.append((sample['time'] - start_x) / MICROSECONDS_IN_SECOND)
- y_values.append(sample['value'])
+ x_values = []
+ y_values = []
+ start_x = None
+ samples = metric['samples']
+ samples.sort(key=lambda x: x['time'])
+ for sample in samples:
+ if start_x is None:
+ start_x = sample['time']
+ # Time is us, we want to show it in seconds.
+ x_values.append(
+ (sample['time'] - start_x) / MICROSECONDS_IN_SECOND)
+ y_values.append(sample['value'])
- plt.ylabel('%s (%s)' % (metric[GRAPH_NAME], metric[UNITS]))
- plt.xlabel('time (s)')
- plt.title(metric[GRAPH_NAME])
- plt.plot(x_values, y_values)
+ plt.ylabel('%s (%s)' % (metric[GRAPH_NAME], metric[UNITS]))
+ plt.xlabel('time (s)')
+ plt.title(metric[GRAPH_NAME])
+ plt.plot(x_values, y_values)
- plt.show()
+ plt.show()
if __name__ == '__main__':
- main()
+ main()