commit 88df0bc5912d55ab272a1b352e2ae80e6e7668c0
author ehmaldonado <ehmaldonado@webrtc.org> Fri Feb 10 09:27:14 2017 -0800
committer Commit bot <commit-bot@chromium.org> Fri Feb 10 17:27:14 2017 +0000
tree 3f6e8af82ae9a3d82d35875b723240b48512d8a2
parent 46a0021e4e196da6b9d9b076d3fd5b9ca16924f1

Make functions in fileutils.h use "const std::string&".

This way, the strings are not copied everytime the function is called.

BUG=webrtc:7142
NOTRY=True

Review-Url: https://codereview.webrtc.org/2685583009
Cr-Commit-Position: refs/heads/master@{#16537}

webrtc/test/testsupport/fileutils.cc

diff --git a/webrtc/test/testsupport/fileutils.cc b/webrtc/test/testsupport/fileutils.cc
index c8054ba..2d3ea00 100644
--- a/webrtc/test/testsupport/fileutils.cc
+++ b/webrtc/test/testsupport/fileutils.cc
@@ -101,7 +101,7 @@
   relative_dir_path_set = true;
 }
 
-bool FileExists(std::string& file_name) {
+bool FileExists(const std::string& file_name) {
   struct stat file_info = {0};
   return stat(file_name.c_str(), &file_info) == 0;
 }
@@ -206,7 +206,7 @@
 #endif
 }
 
-bool CreateDir(std::string directory_name) {
+bool CreateDir(const std::string& directory_name) {
   struct stat path_info = {0};
   // Check if the path exists already:
   if (stat(directory_name.c_str(), &path_info) == 0) {
@@ -226,7 +226,8 @@
   return true;
 }
 
-std::string ResourcePath(std::string name, std::string extension) {
+std::string ResourcePath(const std::string& name,
+                         const std::string& extension) {
 #if defined(WEBRTC_IOS)
   return IOSResourcePath(name, extension);
 #else
@@ -270,7 +271,7 @@
 #endif  // defined (WEBRTC_IOS)
 }
 
-size_t GetFileSize(std::string filename) {
+size_t GetFileSize(const std::string& filename) {
   FILE* f = fopen(filename.c_str(), "rb");
   size_t size = 0;
   if (f != NULL) {